[fix](nereids)LogicalProject should always has non-empty project list #18863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
jackwener
previously approved these changes
Apr 20, 2023
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
924060929
reviewed
Apr 20, 2023
| this.projects = ImmutableList.copyOf(Objects.requireNonNull(projects, "projects can not be null")); | ||
| Preconditions.checkArgument(projects != null, "projects can not be null"); | ||
| this.projects = projects.isEmpty() | ||
| ? ImmutableList.of(ExpressionUtils.selectMinimumColumn(child.getOutput())) |
There was a problem hiding this comment.
child maybe unbound, so selectMinimumColumn() at this place could failed
There was a problem hiding this comment.
Thanks for your reminder. Only ColumnPrune rule may produce empty projects, this happens in rewrite phase. So if projects is empty, all plans have been bound already. I added a precondition check to reflect that.
ffb730e to
723c477
Compare
|
run buildall |
morrySnow
approved these changes
Apr 21, 2023
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Apr 22, 2023
Reminiscent
pushed a commit
to Reminiscent/doris
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...