[refactor](exceptionsafe) disallow call new method explicitly #18830

yiguolei · 2023-04-19T13:15:59Z

Proposed changes

disallow call new method explicitly
force to use create_shared or create_unique to use shared ptr
placement new is allowed

reference https://abseil.io/tips/42 to add factory method to all class.
I think we should follow this guide because if throw exception in new method, the program will terminate.

Problem summary

Describe your changes.

Checklist(Required)

Does it affect the original behavior
Has unit tests been added
Has document been added or modified
Does it need to update dependencies
Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

yiguolei · 2023-04-19T13:26:28Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-19T13:32:06Z

be/src/common/smart_ptr_helper.h

+// Not use template like cowhelper to implements this feature because it has problem
+// during inherits
+// TODO try to allow make_unique
+#define DISALLOW_EXPILICT_NEW(TypeName)                                                     \


warning: macro is not used [clang-diagnostic-unused-macros]

#define DISALLOW_EXPILICT_NEW(TypeName) \ ^

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T01:28:27Z

be/src/common/factory_creator.h

+// Not use template like cowhelper to implements this feature because it has problem
+// during inherits
+// TODO try to allow make_unique
+#define ENABLE_FACTORY_CREATOR(TypeName)                                                    \


warning: macro is not used [clang-diagnostic-unused-macros]

#define ENABLE_FACTORY_CREATOR(TypeName) \ ^

github-actions · 2023-04-20T01:28:28Z

be/src/vec/core/block.h

@@ -53,10 +54,11 @@ namespace vectorized {
  */
 class MutableBlock;
 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: friend declaration of 'make_unique' does not match any declaration in namespace 'std' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block); ^

be/src/common/factory_creator.h:52: expanded from macro 'ENABLE_FACTORY_CREATOR'

friend std::unique_ptr<T> std::make_unique(Args&&... args);\ ^

github-actions · 2023-04-20T01:28:28Z

be/src/vec/core/block.h

@@ -53,10 +54,11 @@ namespace vectorized {
  */
 class MutableBlock;
 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: extra ';' inside a class [clang-diagnostic-extra-semi]

Suggested change

ENABLE_FACTORY_CREATOR(Block)

ENABLE_FACTORY_CREATOR(Block)

github-actions · 2023-04-20T01:28:28Z

be/src/vec/core/block.h

@@ -383,6 +385,8 @@ using BlocksPtr = std::shared_ptr<Blocks>;
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: friend declaration of 'make_unique' does not match any declaration in namespace 'std' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock); ^

be/src/common/factory_creator.h:52: expanded from macro 'ENABLE_FACTORY_CREATOR'

friend std::unique_ptr<T> std::make_unique(Args&&... args);\ ^

github-actions · 2023-04-20T01:28:28Z

be/src/vec/core/block.h

@@ -383,6 +385,8 @@ using BlocksPtr = std::shared_ptr<Blocks>;
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: extra ';' inside a class [clang-diagnostic-extra-semi]

Suggested change

ENABLE_FACTORY_CREATOR(MutableBlock)

ENABLE_FACTORY_CREATOR(MutableBlock)

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T01:33:33Z

be/src/vec/core/block.h

@@ -53,10 +54,11 @@ namespace vectorized {
  */
 class MutableBlock;
 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: friend declaration of 'make_unique' does not match any declaration in namespace 'std' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:52: expanded from macro 'ENABLE_FACTORY_CREATOR'

friend std::unique_ptr<T> std::make_unique(Args&&... args);\ ^

github-actions · 2023-04-20T01:33:33Z

be/src/vec/core/block.h

@@ -383,6 +385,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: friend declaration of 'make_unique' does not match any declaration in namespace 'std' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:52: expanded from macro 'ENABLE_FACTORY_CREATOR'

friend std::unique_ptr<T> std::make_unique(Args&&... args);\ ^

yiguolei · 2023-04-20T01:40:57Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T01:48:52Z

be/src/vec/exec/scan/pip_scanner_context.h

-                auto block = std::make_unique<vectorized::Block>(_output_tuple_desc->slots(),
-                                                                 real_block_size,
-                                                                 true /*ignore invalid slots*/);
+                auto block = vectorized::Block::create_unique(_output_tuple_desc->slots(),


warning: member access into incomplete type 'const doris::TupleDescriptor' [clang-diagnostic-error]

auto block = vectorized::Block::create_unique(_output_tuple_desc->slots(), ^

be/src/vec/core/block.h:51: forward declaration of 'doris::TupleDescriptor'

class TupleDescriptor; ^

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T02:31:57Z

be/src/common/factory_creator.h

+// Not use template like cowhelper to implements this feature because it has problem
+// during inherits
+// TODO try to allow make_unique
+#define ENABLE_FACTORY_CREATOR(TypeName)                                                           \


warning: macro is not used [clang-diagnostic-unused-macros]

#define ENABLE_FACTORY_CREATOR(TypeName) \ ^

github-actions · 2023-04-20T02:31:57Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@ namespace vectorized {
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: expected ';' after return statement [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:45: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, void* place) { return ::operator delete(ptr, place) } \ ^

github-actions · 2023-04-20T02:31:57Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: no matching function for call to 'operator delete' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:43: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, std::size_t size) { return ::operator delete(ptr, size); } \ ^

/usr/include/c++/11/new:179: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete (void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:143: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:152: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete(void*, std::align_val_t) ^

/usr/include/c++/11/new:129: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete(void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:154: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete(void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:31:58Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: use of undeclared identifier 'size' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:44: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete[](void* ptr, std::size_t sz) { return ::operator delete(ptr, size); } \ ^

github-actions · 2023-04-20T02:31:58Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: expected ';' after return statement [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:45: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, void* place) { return ::operator delete(ptr, place) } \ ^

github-actions · 2023-04-20T02:31:58Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: no matching function for call to 'operator delete' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:43: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, std::size_t size) { return ::operator delete(ptr, size); } \ ^

/usr/include/c++/11/new:179: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete (void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:143: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:152: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete(void*, std::align_val_t) ^

/usr/include/c++/11/new:129: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete(void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:154: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete(void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:31:58Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: use of undeclared identifier 'size' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:44: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete[](void* ptr, std::size_t sz) { return ::operator delete(ptr, size); } \ ^

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T02:33:50Z

be/src/common/factory_creator.h

+// Not use template like cowhelper to implements this feature because it has problem
+// during inherits
+// TODO try to allow make_unique
+#define ENABLE_FACTORY_CREATOR(TypeName)                                                           \


warning: macro is not used [clang-diagnostic-unused-macros]

#define ENABLE_FACTORY_CREATOR(TypeName) \ ^

github-actions · 2023-04-20T02:33:50Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@ namespace vectorized {
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: expected ';' after return statement [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:45: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, void* place) { return ::operator delete(ptr, place) } \ ^

github-actions · 2023-04-20T02:33:50Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: no matching function for call to 'operator delete' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:43: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, std::size_t size) { return ::operator delete(ptr, size); } \ ^

/usr/include/c++/11/new:179: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete (void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:143: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:152: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete(void*, std::align_val_t) ^

/usr/include/c++/11/new:129: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete(void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:154: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete(void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:33:51Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: expected ';' after return statement [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:45: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, void* place) { return ::operator delete(ptr, place) } \ ^

github-actions · 2023-04-20T02:33:51Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: no matching function for call to 'operator delete' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:43: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, std::size_t size) { return ::operator delete(ptr, size); } \ ^

/usr/include/c++/11/new:179: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete (void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:143: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:152: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete(void*, std::align_val_t) ^

/usr/include/c++/11/new:129: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete(void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:154: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete(void*, std::align_val_t, const std::nothrow_t&) ^

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T02:37:17Z

be/src/common/factory_creator.h

+// Not use template like cowhelper to implements this feature because it has problem
+// during inherits
+// TODO try to allow make_unique
+#define ENABLE_FACTORY_CREATOR(TypeName)                                                    \


warning: macro is not used [clang-diagnostic-unused-macros]

#define ENABLE_FACTORY_CREATOR(TypeName) \ ^

github-actions · 2023-04-20T02:37:17Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@ namespace vectorized {
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: no matching function for call to 'operator delete' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:43: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, std::size_t size) { return ::operator delete(ptr, size); } \ ^

/usr/include/c++/11/new:179: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete (void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:143: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:152: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete(void*, std::align_val_t) ^

/usr/include/c++/11/new:129: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete(void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:154: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete(void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:37:17Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: no matching function for call to 'operator delete[]' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:44: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete[](void* ptr, std::size_t size) { return ::operator delete[](ptr, size); } \ ^

/usr/include/c++/11/new:180: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete[](void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:145: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete[](void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:160: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete[](void*, std::align_val_t) ^

/usr/include/c++/11/new:131: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete[](void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:162: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete[](void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:37:18Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: no matching function for call to 'operator delete' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:43: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, std::size_t size) { return ::operator delete(ptr, size); } \ ^

/usr/include/c++/11/new:179: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete (void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:143: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:152: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete(void*, std::align_val_t) ^

/usr/include/c++/11/new:129: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete(void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:154: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete(void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:37:18Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: no matching function for call to 'operator delete[]' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:44: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete[](void* ptr, std::size_t size) { return ::operator delete[](ptr, size); } \ ^

/usr/include/c++/11/new:180: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete[](void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:145: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete[](void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:160: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete[](void*, std::align_val_t) ^

/usr/include/c++/11/new:131: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete[](void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:162: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete[](void*, std::align_val_t, const std::nothrow_t&) ^

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T02:42:59Z

be/src/common/factory_creator.h

+// Not use template like cowhelper to implements this feature because it has problem
+// during inherits
+// TODO try to allow make_unique
+//


warning: macro is not used [clang-diagnostic-unused-macros]

#define ENABLE_FACTORY_CREATOR(TypeName) \ ^

github-actions · 2023-04-20T02:42:59Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@ namespace vectorized {
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: no matching function for call to 'operator delete' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:43: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, std::size_t size) { ::operator delete(ptr, size); } \ ^

/usr/include/c++/11/new:179: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete (void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:143: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:152: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete(void*, std::align_val_t) ^

/usr/include/c++/11/new:129: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete(void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:154: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete(void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:42:59Z

be/src/vec/core/block.h

@@ -67,10 +68,11 @@
 class MutableBlock;

 class Block {
+    ENABLE_FACTORY_CREATOR(Block)


warning: no matching function for call to 'operator delete[]' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(Block) ^

be/src/common/factory_creator.h:44: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete[](void* ptr, std::size_t size) { ::operator delete[](ptr, size); } \ ^

/usr/include/c++/11/new:180: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete[](void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:145: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete[](void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:160: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete[](void*, std::align_val_t) ^

/usr/include/c++/11/new:131: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete[](void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:162: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete[](void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:43:00Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: no matching function for call to 'operator delete' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:43: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete(void* ptr, std::size_t size) { ::operator delete(ptr, size); } \ ^

/usr/include/c++/11/new:179: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete (void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:143: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete(void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:152: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete(void*, std::align_val_t) ^

/usr/include/c++/11/new:129: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete(void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:154: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete(void*, std::align_val_t, const std::nothrow_t&) ^

github-actions · 2023-04-20T02:43:00Z

be/src/vec/core/block.h

@@ -397,6 +399,8 @@
 using BlocksPtrs = std::shared_ptr<std::vector<BlocksPtr>>;

 class MutableBlock {
+    ENABLE_FACTORY_CREATOR(MutableBlock)


warning: no matching function for call to 'operator delete[]' [clang-diagnostic-error]

ENABLE_FACTORY_CREATOR(MutableBlock) ^

be/src/common/factory_creator.h:44: expanded from macro 'ENABLE_FACTORY_CREATOR'

void operator delete[](void* ptr, std::size_t size) { ::operator delete[](ptr, size); } \ ^

/usr/include/c++/11/new:180: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'void *' for 2nd argument; take the address of the argument with &

inline void operator delete[](void*, void*) _GLIBCXX_USE_NOEXCEPT { } ^

/usr/include/c++/11/new:145: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument

void operator delete[](void*, const std::nothrow_t&) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:160: candidate function not viable: no known conversion from 'std::size_t' (aka 'unsigned long') to 'std::align_val_t' for 2nd argument

void operator delete[](void*, std::align_val_t) ^

/usr/include/c++/11/new:131: candidate function not viable: requires 1 argument, but 2 were provided

void operator delete[](void*) _GLIBCXX_USE_NOEXCEPT ^

/usr/include/c++/11/new:162: candidate function not viable: requires 3 arguments, but 2 were provided

void operator delete[](void*, std::align_val_t, const std::nothrow_t&) ^

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T02:50:23Z

be/src/common/factory_creator.h

+// during inherits
+// TODO try to allow make_unique
+//
+#define ENABLE_FACTORY_CREATOR(TypeName)                                                     \


warning: macro is not used [clang-diagnostic-unused-macros]

#define ENABLE_FACTORY_CREATOR(TypeName) \ ^

github-actions

clang-tidy made some suggestions

github-actions · 2023-04-20T02:56:55Z

be/src/common/factory_creator.h

+// during inherits
+// TODO try to allow make_unique
+//
+#define ENABLE_FACTORY_CREATOR(TypeName)                                                     \


warning: macro is not used [clang-diagnostic-unused-macros]

#define ENABLE_FACTORY_CREATOR(TypeName) \ ^

yiguolei · 2023-04-20T04:49:25Z

run buildall

yiguolei · 2023-04-20T05:34:49Z

run buildall

yiguolei · 2023-04-20T08:34:24Z

run p0

yiguolei · 2023-04-20T11:16:45Z

run buildall

Gabriel39

LGTM

github-actions · 2023-04-21T01:10:20Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-04-21T01:10:25Z

PR approved by anyone and no changes requested.

…#18830) disallow call new method explicitly force to use create_shared or create_unique to use shared ptr placement new is allowed reference https://abseil.io/tips/42 to add factory method to all class. I think we should follow this guide because if throw exception in new method, the program will terminate. --------- Co-authored-by: yiguolei <yiguolei@gmail.com>

…apache#18830)" This reverts commit 7471ff2.

…#18830) disallow call new method explicitly force to use create_shared or create_unique to use shared ptr placement new is allowed reference https://abseil.io/tips/42 to add factory method to all class. I think we should follow this guide because if throw exception in new method, the program will terminate. --------- Co-authored-by: yiguolei <yiguolei@gmail.com>

…apache#18830)" This reverts commit 7471ff2.

github-actions bot added the area/vectorization label Apr 19, 2023

github-actions bot reviewed Apr 19, 2023

View reviewed changes

github-actions bot reviewed Apr 20, 2023

View reviewed changes

yiguolei force-pushed the smart_ptr_helper branch from 3ed7143 to be3e290 Compare April 20, 2023 01:38

github-actions bot reviewed Apr 20, 2023

View reviewed changes

Doris-Extras added 12 commits April 20, 2023 19:15

[refactor](exceptionsafe) disallow call new method explicitly

7acd76f

f

5e54d9c

f

5376ae8

f

3cc54b3

f

f5e1b51

f

5c7e780

f

5f40fa5

f

b968f22

f

3516231

f

957bee5

f

9236343

f

aeae2e0

yiguolei force-pushed the smart_ptr_helper branch from f320d79 to aeae2e0 Compare April 20, 2023 11:15

Gabriel39 approved these changes Apr 21, 2023

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 21, 2023

github-actions bot added the reviewed label Apr 21, 2023

yiguolei merged commit 63a76ed into apache:master Apr 21, 2023

xiaokang added a commit to xiaokang/doris that referenced this pull request Apr 24, 2023

Revert "[refactor](exceptionsafe) disallow call new method explicitly (…

3d13c06

…apache#18830)" This reverts commit 7471ff2.

gnehil pushed a commit to gnehil/doris that referenced this pull request Jul 13, 2023

Revert "[refactor](exceptionsafe) disallow call new method explicitly (…

80c0bed

…apache#18830)" This reverts commit 7471ff2.

gnehil pushed a commit to gnehil/doris that referenced this pull request Jul 25, 2023

Revert "[refactor](exceptionsafe) disallow call new method explicitly (…

7660a13

…apache#18830)" This reverts commit 7471ff2.

	ENABLE_FACTORY_CREATOR(MutableBlock)
	ENABLE_FACTORY_CREATOR(MutableBlock)

[refactor](exceptionsafe) disallow call new method explicitly #18830

[refactor](exceptionsafe) disallow call new method explicitly #18830

Conversation

yiguolei commented Apr 19, 2023 • edited Loading

Proposed changes

Problem summary

Checklist(Required)

Further comments

yiguolei commented Apr 19, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 19, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

yiguolei commented Apr 20, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 20, 2023

Choose a reason for hiding this comment

yiguolei commented Apr 19, 2023 •

edited

Loading