[bug](bdbje) Add retry for reSetupBdbEnvironment() restore.execute()
#18777
Conversation
| for (int i = 0; i < RETRY_TIME; i++) { | ||
| try { | ||
| NetworkRestore restore = new NetworkRestore(); | ||
| NetworkRestoreConfig config = new NetworkRestoreConfig(); | ||
| config.setRetainLogFiles(false); | ||
| restore.execute(insufficientLogEx, config); |
There was a problem hiding this comment.
I'm not familiar with the logic here, but it looks like you're retrying up to the maximum number of times, even if it was successful before then.
There was a problem hiding this comment.
I'm not familiar with the logic here, but it looks like you're retrying up to the maximum number of times, even if it was successful before then.
Thanks for your comment, i have added a break here.
* In reSetupBdbEnvironment() `restore.execute()` may throw NullPointerException, add retry for `restore.execute()`
1f3c667 to
74008c4
Compare
|
run buildall |
|
TeamCity pipeline, clickbench performance test result: |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
apache#18777) * In reSetupBdbEnvironment() `restore.execute()` may throw NullPointerException, add retry for `restore.execute()`
apache#18777) * In reSetupBdbEnvironment() `restore.execute()` may throw NullPointerException, add retry for `restore.execute()`
#18777) * In reSetupBdbEnvironment() `restore.execute()` may throw NullPointerException, add retry for `restore.execute()`
apache#18777) * In reSetupBdbEnvironment() `restore.execute()` may throw NullPointerException, add retry for `restore.execute()`
apache#18777) * In reSetupBdbEnvironment() `restore.execute()` may throw NullPointerException, add retry for `restore.execute()`
restore.execute()may throw NullPointerException, add retry forrestore.execute()Proposed changes
Issue Number: close #18766
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...