[Fix](Nereids)Check bounding of expression in analyze process #18581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
1 similar comment
|
run buildall |
a842465 to
44d3762
Compare
|
run buildall |
44d3762 to
ebd9dfb
Compare
|
run buildall |
2 similar comments
|
run buildall |
|
run buildall |
|
run clickbench |
morrySnow
previously approved these changes
Apr 19, 2023
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…ounding and before apply more complex analyze rules
ebd9dfb to
b1a002a
Compare
|
run buildall |
|
TeamCity pipeline, clickbench performance test result: |
morrySnow
approved these changes
Apr 20, 2023
|
PR approved by at least one committer and no changes requested. |
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Apr 21, 2023
…pache#18581) Probleam: Dead loop cause of keep pushing analyze tasks into job stack. When doing analyze process and generate new operators, the same analyze rule would be pushed again, so it cause dead loop. And analyze process generate new operators when trying to bound order by key and aggregate function. Solve: We need to make it throw exception before complex analyze and rewrite process, so checking whether all expressions being bound should be done twice. One is done after bounding all expression, another is done after all analyze process in case of generate new expressions and new operators. Example: Cases were put in file: regression-test/suites/nereids_p0/except/test_bound_exception.groovy
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…pache#18581) Probleam: Dead loop cause of keep pushing analyze tasks into job stack. When doing analyze process and generate new operators, the same analyze rule would be pushed again, so it cause dead loop. And analyze process generate new operators when trying to bound order by key and aggregate function. Solve: We need to make it throw exception before complex analyze and rewrite process, so checking whether all expressions being bound should be done twice. One is done after bounding all expression, another is done after all analyze process in case of generate new expressions and new operators. Example: Cases were put in file: regression-test/suites/nereids_p0/except/test_bound_exception.groovy
jackwener
pushed a commit
to jackwener/doris
that referenced
this pull request
Apr 21, 2023
…pache#18581) Probleam: Dead loop cause of keep pushing analyze tasks into job stack. When doing analyze process and generate new operators, the same analyze rule would be pushed again, so it cause dead loop. And analyze process generate new operators when trying to bound order by key and aggregate function. Solve: We need to make it throw exception before complex analyze and rewrite process, so checking whether all expressions being bound should be done twice. One is done after bounding all expression, another is done after all analyze process in case of generate new expressions and new operators. Example: Cases were put in file: regression-test/suites/nereids_p0/except/test_bound_exception.groovy
jackwener
pushed a commit
to jackwener/doris
that referenced
this pull request
Apr 21, 2023
…pache#18581) Probleam: Dead loop cause of keep pushing analyze tasks into job stack. When doing analyze process and generate new operators, the same analyze rule would be pushed again, so it cause dead loop. And analyze process generate new operators when trying to bound order by key and aggregate function. Solve: We need to make it throw exception before complex analyze and rewrite process, so checking whether all expressions being bound should be done twice. One is done after bounding all expression, another is done after all analyze process in case of generate new expressions and new operators. Example: Cases were put in file: regression-test/suites/nereids_p0/except/test_bound_exception.groovy
Reminiscent
pushed a commit
to Reminiscent/doris
that referenced
this pull request
May 15, 2023
…pache#18581) Probleam: Dead loop cause of keep pushing analyze tasks into job stack. When doing analyze process and generate new operators, the same analyze rule would be pushed again, so it cause dead loop. And analyze process generate new operators when trying to bound order by key and aggregate function. Solve: We need to make it throw exception before complex analyze and rewrite process, so checking whether all expressions being bound should be done twice. One is done after bounding all expression, another is done after all analyze process in case of generate new expressions and new operators. Example: Cases were put in file: regression-test/suites/nereids_p0/except/test_bound_exception.groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probleam:
Dead loop cause of keep pushing analyze tasks into job stack. When doing analyze process and generate new operators, the same analyze rule would be pushed again, so it cause dead loop. And analyze process generate new operators when trying to bound order by key and aggregate function.
Solve:
We need to make it throw exception before complex analyze and rewrite process, so checking whether all expressions being bound should be done twice. One is done after bounding all expression, another is done after all analyze process in case of generate new expressions and new operators.
Example:
Cases were put in file: regression-test/suites/nereids_p0/except/test_bound_exception.groovy
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...