Skip to content

Commit

Permalink
test
Browse files Browse the repository at this point in the history
  • Loading branch information
eldenmoon committed Dec 14, 2023
1 parent 0a033c0 commit 81f25e4
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions be/src/service/internal_service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1781,7 +1781,7 @@ Status PInternalServiceImpl::_multi_get(const PMultiGetRequest& request,
}

std::unordered_map<IteratorKey, IteratorItem, HashOfIteratorKey> iterator_map;

SegmentCacheHandle segment_cache_handles;
// read row by row
for (size_t i = 0; i < request.row_locs_size(); ++i) {
const auto& row_loc = request.row_locs(i);
Expand Down Expand Up @@ -1831,6 +1831,7 @@ Status PInternalServiceImpl::_multi_get(const PMultiGetRequest& request,
segment_v2::SegmentSharedPtr segment = *it;
GlobalRowLoacation row_location(row_loc.tablet_id(), rowset->rowset_id(),
row_loc.segment_id(), row_loc.ordinal_id());
segment_cache_handles.push_segment(segment);
// fetch by row store, more effcient way
if (request.fetch_row_store()) {
CHECK(tablet->tablet_schema()->store_row_column());
Expand Down Expand Up @@ -1863,7 +1864,7 @@ Status PInternalServiceImpl::_multi_get(const PMultiGetRequest& request,
.segment_id = row_loc.segment_id(),
.slot_id = desc.slots()[x]->id()};
// hold the reference
iterator_map[iterator_key].segment = segment;
// iterator_map[iterator_key].segment = segment;
RETURN_IF_ERROR(segment->seek_and_read_by_rowid(full_read_schema, desc.slots()[x],
row_id, column, stats,
iterator_map[iterator_key].iterator));
Expand Down

0 comments on commit 81f25e4

Please sign in to comment.