Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to Apache DS 2.0.0.AM27 and LDAP API 2.1.5 #275

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

coheigea
Copy link
Contributor

No description provided.

@coheigea coheigea force-pushed the coheigea/DIRKRB-770 branch from ca6b079 to 4690a56 Compare October 26, 2023 14:55
@coheigea
Copy link
Contributor Author

@elecharny Do you know why the LDAP tests in Kerby would fail on updating Apache DS with:

2023-10-26T15:00:36.5217069Z java.lang.NoSuchFieldException: classDirectoryService
2023-10-26T15:00:36.5217749Z 	at java.lang.Class.getField(Class.java:1703)
2023-10-26T15:00:36.5218991Z 	at org.apache.directory.server.core.integ.ApacheDSTestExtension.setDirectoryService(ApacheDSTestExtension.java:81)
2023-10-26T15:00:36.5220737Z 	at org.apache.directory.server.core.integ.ApacheDSTestExtension.beforeAll(ApacheDSTestExtension.java:179)

@elecharny
Copy link
Contributor

Hi Colm,

I have changed the test framework from junit4 to junit5.

The class that were using @RunWith(FrameworkRunner.class) should now use @ExtendWith( ApacheDSTestExtension.class )

I think this is the pb you have.

@coheigea
Copy link
Contributor Author

@elecharny It's not the problem, the PR upgrades to ApacheDSTestExtension :-)

@elecharny
Copy link
Contributor

@coheigea Sorry, a bit busy those days. I'll have a look at it in the coming days.

@elecharny
Copy link
Contributor

elecharny commented Nov 6, 2023

@coheigea be sure that the test class extends AbstractLdapTestUnit. I had to declare the fields in this class as static members.

(or you can move the code from this class to one of the class you extend)

Don't ask, the Junit4 -> Junit5 migration was an ugly mess :/

@coheigea
Copy link
Contributor Author

coheigea commented Nov 7, 2023

@elecharny Thanks, I've been able to work around it with that hint

@coheigea coheigea force-pushed the coheigea/DIRKRB-770 branch 2 times, most recently from a73cb19 to e24cf8a Compare November 7, 2023 06:48
@coheigea coheigea force-pushed the coheigea/DIRKRB-770 branch from e24cf8a to 098378f Compare November 7, 2023 07:12
@coheigea coheigea merged commit d3c4aec into trunk Nov 7, 2023
@coheigea coheigea deleted the coheigea/DIRKRB-770 branch November 7, 2023 07:19
@elecharny
Copy link
Contributor

Sorry for the time it took me to analyze the issue. Actually, another Apache fellow had the same issue last week, so I spent the couple of hours to understand the root cause.

Glad it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants