Add MSRV check as a GA job #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Thank you very much @sarutak - this looks great
Can you possibly also:
-
Add
datafusion-cli -
Add a comment in Cargo.toml saying why these three (four with
datafusion-cli) are picked? Namely that they are the crates that are directly used by other projects?
However, I think these changes could be done as a follow on PR as well and this one could be merged as is.
|
@alamb |
|
Thanks again @sarutak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7122
Rationale for this change
Sometimes,
rust-versionin Cargo.toml tends to be out of sync with the actual MSRV.So, it's nice to have a MSRV check as a CI process.
What changes are included in this PR?
Added a MSRV check job to GA for some packages
datafusion,datafusion-substrait,datafusion-protoanddatafusion-cliwhich are intended to be published.The following packages are also intended to be published but
datafusiondepends on them. So, this PR doesn't include MSRV check for them.Are these changes tested?
GA.
Are there any user-facing changes?
No