Deprecate invoke and invoke_no_args in favor of invoke_batch #13174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires lots of changes, so let's do this incrementally. |
`invoke_batch` covers all needs, so let's deprecate and eventually remove the redundant variants.
04c8611 to
13e57b2
Compare
To be followed-up on.
alamb
approved these changes
Nov 3, 2024
| @@ -489,19 +493,40 @@ pub trait ScalarUDFImpl: Debug + Send + Sync { | |||
|
|
|||
| /// Invoke the function with `args` and the number of rows, | |||
| /// returning the appropriate result. | |||
| /// | |||
| /// The function will be invoked with the slice of [`ColumnarValue`] | |||
please add a label |
This was referenced Nov 3, 2024
…in-favor-of-invoke-batch-dd2bd8
|
Pushed a commit fixing logical conflict with #13130 that was merged recently. |
|
cc @comphead |
|
Looks good -- thanks @findepi |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke_batchcovers all needs, so let's deprecate and eventually remove the redundant variants.Deprecate ScalarUDF::invoke and invoke_no_args for invoke_batch #13179 deprecated functions in ScalarUDF, this PR deprecates equivalent functions in ScalarUDFImpl trait.
follows Fix functions with Volatility::Volatile and parameters #13001
follows Deprecate ScalarUDF::invoke and invoke_no_args for invoke_batch #13179