Fix Internal Error for an INNER JOIN query #11578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11412
Rationale for this change
This issue has affected the
join using
query with type coercions, for the specific query in this issue.The type_coercion transform
Column(c)
toCast(Column(c)
https://github.com/apache/datafusion/blob/5da7ab300215c44ca5dc16771091890de22af99b/datafusion/optimizer/src/analyzer/type_coercion.rs#L180C1-L195C6
Then in the
using_columns
the issue pops up.https://github.com/apache/datafusion/blob/5da7ab300215c44ca5dc16771091890de22af99b/datafusion/expr/src/logical_plan/plan.rs#L497C1-L512C25
This also indicates the
using_columns
should not be called after type_coercionWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?