use safe cast in propagate_constraints #11297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like an arrow-rs related problem, but we can use safe cast to avoid it temporarily |
alamb
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Thank you @Lordworms
I have one small suggestion for additional test coverage but I don't think it is required
| query I | ||
| select * from t0 where v0>1e100; | ||
| ---- | ||
|
|
There was a problem hiding this comment.
I suggest a test that also shows the filter passing (I wasn't sure if the whole thing was turned into NULL). But I double checked and this query works on this branch:
Suggested change
| query I | |
| select * from t0 where v0<1e100; | |
| ---- | |
| 1 | |
| 2 | |
| 3 | |
|
Thanks @Lordworms 🙏 |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* use safe cast in propagate_constraints * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11252
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?