New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TPCH substrait integration teset, support tpch_2 #11234

Merged

alamb merged 4 commits into apache:main from Lordworms:issue_10710_2

Jul 5, 2024

Contributor

Lordworms commented Jul 2, 2024

Which issue does this PR close?

part of #10710

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

github-actions bot added the substrait label


          integrate tpch query 2

abf5cd9

avoid cloning

optimize code

optimize code

Lordworms force-pushed the issue_10710_2 branch from f04838d to abf5cd9 Compare

July 2, 2024 22:44

alamb approved these changes

View reviewed changes

Contributor

alamb left a comment

Thank. you @Lordworms -- I gave this a quick look and it looks good to me

I wouldn't be surprosed if there is some additional work for some of the other expressions (e.g. how to plan like, etc) but this seems like a nice step forward.

cc @Blizzara in case you would like to review.

Blizzara reviewed

View reviewed changes

datafusion/substrait/src/logical_plan/consumer.rs Outdated Show resolved Hide resolved

Blizzara reviewed

View reviewed changes

datafusion/substrait/tests/cases/consumer_integration.rs Show resolved Hide resolved

Blizzara reviewed

View reviewed changes

datafusion/substrait/src/logical_plan/consumer.rs Outdated Show resolved Hide resolved

Blizzara reviewed

View reviewed changes

datafusion/substrait/src/logical_plan/consumer.rs Outdated Show resolved Hide resolved

Blizzara reviewed

View reviewed changes

datafusion/substrait/src/logical_plan/consumer.rs Outdated Show resolved Hide resolved


          optimize code

507999e

Contributor Author

Lordworms commented Jul 3, 2024

@Blizzara and @alamb Hi, I have resolved the review, plz take a look, Thanks for your code review, appreciate it.

Lordworms requested a review from Blizzara

July 3, 2024 22:26

Blizzara reviewed

View reviewed changes

datafusion/substrait/src/logical_plan/consumer.rs Outdated Show resolved Hide resolved


          refactor code

d5075f1

Blizzara approved these changes

View reviewed changes

Contributor

Blizzara left a comment

Thanks, looks great to me! Extra thanks for adding the subquery support and bringing some order to the imports :)


          format

d360526

alamb merged commit 0d2525e into apache:main

23 checks passed

Contributor

alamb commented Jul 5, 2024

Thanks again @Lordworms and @Blizzara

comphead pushed a commit to comphead/arrow-datafusion that referenced this pull request


          Implement TPCH substrait integration teset, support tpch_2 (apache#11234

80f7bcd

)

* integrate tpch query 2

avoid cloning

optimize code

optimize code

* optimize code

* refactor code

* format

findepi pushed a commit to findepi/datafusion that referenced this pull request


          Implement TPCH substrait integration teset, support tpch_2 (apache#11234

2233ea4

)

* integrate tpch query 2

avoid cloning

optimize code

optimize code

* optimize code

* refactor code

* format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels