Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateIndex: Move Display fmt to struct #1307

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

philipcristiano
Copy link
Contributor

Move the Display trait fmt implementation to the CreateIndex struct to to allow for display!

The struct was created in a0f511c with the CreateTable fmt being moved, but the CreateIndex was not.

Follows up from #1291

Move the Display trait `fmt` implementation to the CreateIndex struct to
to allow for display!

The struct was created in a0f511c with
the CreateTable `fmt` being moved, but the CreateIndex was not.

Follows up from apache#1291
@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9467753604

Details

  • 25 of 27 (92.59%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 88.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/dml.rs 24 26 92.31%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 81.5%
Totals Coverage Status
Change from base Build 9439708625: 0.004%
Covered Lines: 26254
Relevant Lines: 29538

💛 - Coveralls

Copy link
Contributor

@jmhain jmhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice -- thank you @philipcristiano and @jmhain

@alamb alamb merged commit deac269 into apache:main Jun 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants