Return errors, not panic, when integers fail to parse in AUTO_INCREMENT and TOP

[eejbyfeldt]

This fixes several places where the code currently panic when parsing an integer value. This change makes us return the error instead.

This replaces #1304 by also handling one more cases and introducing a helper method that can be used in all places when an integer value needs to be parsed.

Closes #1303

[lovasoa]

Wow, this is a big problem, especially for people like me who use sqlparser inside a web server. @alamb, can we prioritize merging this ?

[alamb]

Looks good to me -- thank you @eejbyfeldt and @lovasoa

[coveralls]

Pull Request Test Coverage Report for Build 9454797383

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 23 of 24 (95.83%) changed or added relevant lines in 2 files are covered.
• 12 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.09%) to 88.968%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tests/sqlparser_common.rs	8	9	88.89%

Files with Coverage Reduction	New Missed Lines	%
src/lib.rs	1	12.64%
src/parser/alter.rs	2	66.67%
tests/sqlparser_common.rs	4	89.57%
src/dialect/mod.rs	5	72.08%

Totals
Change from base Build 9439708625:	0.09%
Covered Lines:	26144
Relevant Lines:	29386

---

💛 - Coveralls

[alamb]

There appears to be a CI failure on this PR: https://github.com/sqlparser-rs/sqlparser-rs/actions/runs/9454797383/job/26361666986?pr=1305

[eejbyfeldt]

There appears to be a CI failure on this PR: https://github.com/sqlparser-rs/sqlparser-rs/actions/runs/9454797383/job/26361666986?pr=1305

Fixed the issue. And enabled CI on my fork to catch these kind of issues earlier next time.

[coveralls]

Pull Request Test Coverage Report for Build 9565500013

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
• 610 unchanged lines in 7 files lost coverage.
• Overall coverage increased (+0.09%) to 88.972%

---

Files with Coverage Reduction	New Missed Lines	%
src/lib.rs	1	12.64%
src/parser/alter.rs	2	66.67%
src/dialect/mod.rs	5	72.08%
src/ast/dml.rs	42	73.47%
src/parser/mod.rs	112	93.2%
src/ast/mod.rs	192	81.5%
tests/sqlparser_common.rs	256	89.58%

Totals
Change from base Build 9439708625:	0.09%
Covered Lines:	26141
Relevant Lines:	29381

---

💛 - Coveralls

[alamb]

Thanks again @eejbyfeldt