Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CREATE FUNCTION for BigQuery #1253

Merged
merged 1 commit into from
May 30, 2024

Conversation

iffyio
Copy link
Contributor

@iffyio iffyio commented May 4, 2024

Adds support for the CREATE FUNCTION statement in BigQuery. Merges with the representation used in the hive/postgres dialects.

https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#create_function_statement

@coveralls
Copy link

coveralls commented May 4, 2024

Pull Request Test Coverage Report for Build 9302309555

Details

  • 228 of 239 (95.4%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 89.502%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_bigquery.rs 34 36 94.44%
src/parser/mod.rs 141 145 97.24%
src/ast/mod.rs 36 41 87.8%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 80.92%
src/parser/mod.rs 3 92.98%
Totals Coverage Status
Change from base Build 9212358328: 0.03%
Covered Lines: 25049
Relevant Lines: 27987

💛 - Coveralls

Copy link
Contributor

@jmhain jmhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iffyio and @jmhain

Adds support for the `CREATE FUNCTION` statement in BigQuery.
Merges with the representation used in the hive/postgres dialects.

https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#create_function_statement
@iffyio iffyio force-pushed the bq-create-function branch from 5c2b7f7 to 87c4979 Compare May 30, 2024 12:13
@alamb alamb merged commit 792e389 into apache:main May 30, 2024
10 checks passed
@iffyio iffyio deleted the bq-create-function branch July 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants