Error on dangling NO in CREATE SEQUENCE options
#1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where a `NO` meant for `NO CACHE` in create options would be consumed without being followed by `CACHE`. Fixes: `#1103`
|
LGTM |
tobyhede
approved these changes
Jan 21, 2024
9 tasks
1103 - disallow dangling NO in create sequence optionsNO in create sequence options
NO in create sequence optionsNO in CREATE SEQUENCE options
Pull Request Test Coverage Report for Build 7632957069Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
alamb
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Thank you @partiallytyped -- this looks great.
It looks like CI is failing due to needing to run cargo fmt -- any chance you can run that and we can get this PR in?
|
Sure, give me a moment. |
No need -- I will do this as part of the merge process |
|
Thanks again @partiallytyped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a
NOmeant forNO CACHEin create options would be consumed without being followed byCACHE.Changelog: Fixes: #1103