Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update android engine requirement <11.0.0 #329

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 1, 2022

Platforms affected

Android

Motivation and Context

The Cordova Android platform has inegrated the Splash Screen plugin as core functionality.
This plugin is no longer needed in in the next majpr release of Cordova Android (11.0.0+).

Description

Update the engine requirement to not install on 11.0.0 or above.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu force-pushed the chore/update-android-requirement branch from 42a8c43 to a02d20c Compare July 1, 2022 03:39
@erisu erisu force-pushed the chore/update-android-requirement branch from a02d20c to 9e584f1 Compare July 1, 2022 03:39
@jcesarmobile
Copy link
Member

Don’t understand the “If using cordova-android@11.x or later, use cordova-plugin-splashscreen@7.x (currently in-development).”

are we going to launch a 7.x version removing the android code?

@erisu
Copy link
Member Author

erisu commented Jul 1, 2022

Yes, 7.x will drop all of the Android code.

@erisu
Copy link
Member Author

erisu commented Jul 1, 2022

I just kept the wording to match how iOS was written.

It can be reworded as

If using cordova-android@11.x or later and exclusively developing for Android, this plugin can be uninstalled.

This entire section will be deleted in version 7.x anyways as the Android docs will be removed.
iOS For example, you can see the statement was removed in this upcoming PR: #331

It should have been removed when 6.0.0 released, but the docs were not migrated at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants