fix: refocus after webview visible (#186) #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erisu, can you please share when the next release would be? This issue has been pending for a very long time. Thanks. |
|
@erisu I have the same issue with my android device (API 30) can you release the new version for us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
android
Motivation and Context
After Android SDK 28, the android buck-button key event can not be handled.
This issue happens because the webview gets out of focus.
This PR made the webview to refocus after url loading.
fixes: #186
Description
Testing
In my local environment I tested by creating sample app with cordova-android 9.1.0 and cordova 10.0.0.
I also run
npm run test.Checklist
(platform)if this change only applies to one platform (e.g.(android))