-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build errors about drawable since upgrading to cordova-android 8.0.0 #185
Comments
It only happens with a production "release" build. |
@BorntraegerMarc Can you please post the complete output of one of these builds? Best with a new Cordova app that you just created to reproduce this error, then it will be even simpler for us to understand. Bonus points if it is a plain Cordova app, not using Ionic (because that removes another variable). Thanks. |
(There is more discussion in the related general cordova-android issue: apache/cordova-android#689) |
(Note this is an almos 1 to 1 copy of apache#228 by @toshihidetagami ### Platforms affected Only docs ### Motivation and Context Current documentation lacks the default resources for Android. On Android, you can provide alternative resources for specific device configuration, like current docs provide alternative resources for portrait and landscape orientation. But error will be thrown if a device configuration does not match any specific alternative resources, so you should provide a default (In this case, without port- or land- ) as a fallback. This change fixes the error reported in apache#185 and [apache/cordova-android#689](apache/cordova-android#689). ### Description [Although orientation is only portrait and landscape as of now](https://developer.android.com/guide/topics/resources/providing-resources#OrientationQualifier), providing default would prevent [MissingDefaultResource lint check error](http://tools.android.com/tips/lint-checks) and considered as [good practice for Android resources configuration](https://developer.android.com/guide/topics/resources/providing-resources#Compatibility). > Likewise, if you provide different layout resources based on the screen orientation, you should pick one orientation as your default. For example, instead of providing layout resources in layout-land/ for landscape and layout-port/ for portrait, leave one as the default, such as layout/ for landscape and layout-port/ for portrait. Note: You don’t have to provide a default for screen density. [The system use whichever resources are the best match](https://developer.android.com/guide/topics/resources/providing-resources#DensityQualifier). ### Testing ### Checklist * [ ] I've run the tests to see all new and existing tests pass * [ ] I added automated test coverage as appropriate for this change * [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) * [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) * [x] I've updated the documentation if necessary
Bug Report
Problem
What is expected to happen?
Building a cordova app with
ionic cordova build android --prod --release
does not throw errors.What does actually happen?
I see this error in the console:
Information
This error was not present in v7.X
I do specify a splash screen in
config.xml
like so:<splash density="land-hdpi" src="resources/android/splash/drawable-land-hdpi-screen.png" />
And it gets displayed correctly (according to my tests so far)
I'm using this plugin to configure the splash screens: https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-splashscreen/
I only included 1 example of the errors I'm getting to keep the bug report small. But I get it for different screen sizes & densities.
I understand that it has something to do with android linting rules: http://tools.android.com/tips/lint-checks
But I don't fully understand if it's a misconfiguration in the plugin or if cordova-android needs to do something differently.
PS: I also posted a bug here apache/cordova-android#689 because I'm not sure where the problem is (if in the plugin or cordova-android).
Command or Code
ionic cordova build android --prod --release
Environment, Platform, Device
On all. It happens on build time.
Version information
Checklist
The text was updated successfully, but these errors were encountered: