Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: bump xcode w/ fix #853

Merged
merged 2 commits into from
May 19, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 16, 2020

Motivation, Context & Description

  • Upgrade xcode
  • Fix prepare & prepare.spec to provide exact targetName

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I upated automated test coverage as appropriate for this change

@erisu erisu added this to the 6.0.0 milestone May 16, 2020
@erisu erisu requested review from dpogue, timbru31 and NiklasMerz May 16, 2020 14:07
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Dependency could be used from NPM once ready. One build test with an app with two extensions was successful

Thanks for your help with this issue 👍

package.json Outdated Show resolved Hide resolved
@erisu erisu force-pushed the breaking/upgrade-xcode-with-fix branch from 1e6bbf7 to b42ad27 Compare May 19, 2020 01:07
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1821     1821           
=======================================
  Hits         1355     1355           
  Misses        466      466           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js 82.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d271f...b42ad27. Read the comment docs.

@erisu erisu merged commit aae6a86 into apache:master May 19, 2020
@erisu erisu deleted the breaking/upgrade-xcode-with-fix branch May 19, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants