Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (cordovaBoolSettingForKey): improve boolean checks and native logging #798

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 23, 2020

Motivation and Context

Improve the boolean checks for preference settings and logging.

Description

Updated the cordovaBoolSettingForKey method.

Testing

  • npm t
  • cordova platform add
  • cordova build
  • Run in simulator and test with different values

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Feb 23, 2020
@erisu erisu requested a review from dpogue February 23, 2020 07:52
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keys are automatically lowercased in the dictionary, but the values are not. It would be best to lowercaseString prefObj before doing any comparisons to catch things like "True"

@erisu erisu force-pushed the refactor/cordovaBoolSettingForKey branch 4 times, most recently from 1251fed to 4e9e953 Compare February 25, 2020 04:43
@erisu erisu force-pushed the refactor/cordovaBoolSettingForKey branch from 4e9e953 to 6ad57c5 Compare February 25, 2020 04:52
@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #798 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #798   +/-   ##
=======================================
  Coverage   74.36%   74.36%           
=======================================
  Files          13       13           
  Lines        1845     1845           
=======================================
  Hits         1372     1372           
  Misses        473      473

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac1552...6ad57c5. Read the comment docs.

@erisu erisu merged commit 62b3dce into apache:master Feb 25, 2020
@erisu erisu deleted the refactor/cordovaBoolSettingForKey branch February 25, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants