CB-14192: (ios) - Xcode 10 Framework Target Fix - Convert Framework to build source rather than wrap static lib #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o build source rather than wrap static lib - The new build system in Xcode 10 gets confused by the static library header files copied to $CONFIGURATION_BUILD_DIR/include - By making the framework target build the source directly we eliminate this issue - If both targets are built, the issue will still occur
- Addresses additional build issues with new build system on Xcode 10
|
I had been hoping to merge this (in the form of #409) once I'd figured out why automatic signing was still broken, but it might make sense to fix this one issue and tackle the signing separately since it's not clear that they are related. |
|
That would be much appreciated, @dpogue! |
|
#409 (which includes the changes from this PR, with credit to sgoldberg-sfdc) has been merged in preparation for the next major version of cordova-ios, so I'm going to close this PR. Thanks for your contribution and for paving the way to support Xcode 10! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
Modifies the framework target to compile the source directly, rather than wrap the static library target. This avoids the issue where the static library header files are copied to the $CONFIGURATION_BUILD_DIR confusing the new build system (defaulted on in Xcode 10) resulting in duplicate definition errors.
What testing has been done on this change?
Manually verified builds of both targets within xcode and via Carthage.
Checklist