Prevent a memory leak when converting to JSON #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of JSONObjectWithData in these methods leaks 4KB each time when used for sending plugin results. Wrapping them in an autoreleasepool fixes this problem with no noticeable detrimental effects on performance.
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 63.45% 63.45%
=======================================
Files 14 14
Lines 1691 1691
Branches 284 284
=======================================
Hits 1073 1073
Misses 618 618Continue to review full report at Codecov.
|
shazron
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of JSONObjectWithData in these methods leaks 4KB each time when used for sending plugin results. Wrapping them in an autoreleasepool fixes this problem with no noticeable detrimental effects on performance.
Platforms affected
iOS
What does this PR do?
Fixes a memory leak in CDVJSONSerializingPrivate methods
What testing has been done on this change?
Using Instruments app on Mac, observed a 4KB increase in memory usage every time these methods were called that does not get released throughout the lifetime of the app. After implementing these changes, the memory usage remains stable.