Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script errors in create.js #8

Closed
wants to merge 2 commits into from
Closed

script errors in create.js #8

wants to merge 2 commits into from

Conversation

ucavus
Copy link

@ucavus ucavus commented Feb 7, 2013

Create scripts should not fail simply because there is a space in the path to the project. I have seen the same type of issue on the iOS create scripts under Mac OS.

@mbillau
Copy link
Contributor

mbillau commented Feb 15, 2013

Verified this fix works on Windows 7 x86 by running create "patch/my app" com.myapp.patch patch which works after applying your patch but did not work before.

@ucavus
Copy link
Author

ucavus commented Apr 22, 2013

Am I putting this pull request in the wrong place? It seems strange to let such a simple bug go unpatched for months when a fix has been provided.

@mbillau
Copy link
Contributor

mbillau commented Apr 22, 2013

No, this is the correct repo, it might have just gotten missed because there is no JIRA item associated with it. I would encourage you to create a bug against Android on the Cordova issue tracker here: https://issues.apache.org/jira/browse/CB Then you can link to the pull request and one of the committeers should see it and pull it in. You could also send an email to the cordova mailing list asking somebody to look at it. However, make sure that you have signed and submitted an Apache ICLA - this is required for licensing before your pull request can be accepted. Maybe this contributed to the delay. Please see http://cordova.apache.org/#contribute for more information. (Also, thanks again for contributing, sorry that this was ignored!)

@agrieve
Copy link
Contributor

agrieve commented Apr 30, 2013

Okay! Yes. Sorry for leaving this stale for so long, but do really appreciate the fix!

I've created a bug for it: https://issues.apache.org/jira/browse/CB-3304

ucavus - just need to see if you've signed the Apache CLA so that I can pull in the code?
Some details at http://cordova.apache.org/#contribute

@ucavus
Copy link
Author

ucavus commented May 1, 2013

I have.

@agrieve
Copy link
Contributor

agrieve commented May 3, 2013

Pulled in your change! Thanks again.

Please close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants