[CB-861] Header support for FileTransfer download #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for an optional options object as the final arg. Currently only handles the options.headers object (as per the issue). `FileTransfer.download(source, target, successCallback, errorCallback, trustAllHosts, options)` This is needed for using FileTransfer.download with Basic Authentication, etc. Sadly since Android 2.x doesn't support XHR2, this is needed in FileTransfer. I have only added support to Android and iOS (see other PR's).
| @@ -615,7 +615,9 @@ private void download(final String source, final String target, JSONArray args, | |||
| Log.d(LOG_TAG, "download " + source + " to " + target); | |||
|
|
|||
| final boolean trustEveryone = args.optBoolean(2); | |||
| final String objectId = args.getString(3); | |||
| final JSONObject headers = args.optJSONObject(3); | |||
| Log.d(LOG_TAG, "headers: " + headers); | |||
There was a problem hiding this comment.
Another case of copying the behaviour of the upload method. It Log.d's all the parameters passed to it.
As per discussion with @agrieve I have moved the addition of the headers to the connection for both the upload and download methods to a helper method.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for an optional options object as the final arg. Currently only handles the options.headers object (as per the issue).
FileTransfer.download(source, target, successCallback, errorCallback, trustAllHosts, options)This is needed for using FileTransfer.download with Basic Authentication, etc. Sadly since Android 2.x doesn't support XHR2, this is needed in FileTransfer.
I have only added support to Android and iOS (see other PR's). It might be that the JS args need to be in a different order or handled differently so that it doesn't impact the other platforms. I am hoping I can get advice on that from someone.
If there is anything else I need to do, just let me know.
//cc @agrieve - for suggesting I do this myself