Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changes.xml to reflect japicmp-maven-plugin update #575

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 11, 2025

follow-up on #574

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

@garydgregory
Copy link
Member

Uh...? Why update the entry for an action that many versions in the past?

@raboof raboof force-pushed the japicmp-update-changes-xml branch from 9b899ce to 8511602 Compare January 11, 2025 01:56
@garydgregory
Copy link
Member

TY @raboof !

@garydgregory garydgregory merged commit dfff255 into apache:master Jan 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants