-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set integration.api.port to 0 (zero) as default. #3504
Set integration.api.port to 0 (zero) as default. #3504
Conversation
CloudStack provides CloudStack API Unauthenticated Access through port 8096. It should not be open to the Internet in any case.
@blueorangutan package |
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this was introduced in b363fd4
@blueorangutan package |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
I ran a fresh environment off the PR based on KVM and still see integration.api.port to be 8096 in GUI. Are there any additional steps involved or is that supposed to be 0 @GabrielBrascher ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question above to double check as I see some different functionality when locally testing.
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-163 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It was maven debugger database thing before
@blueorangutan package |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-166 |
Trillian is full capacity, merging this based on Travis job https://travis-ci.org/apache/cloudstack/jobs/561936104 and lgtms |
Description
CloudStack provides CloudStack API Unauthenticated Access through port
8096. It should not be open to the Internet in any case.
Fixes: #3450
Types of changes
How Has This Been Tested?
Current behavior
integration.api.port
is indeed configured as 8096WIth this PR
integration.api.port
is indeed configured as 0