-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDSTACK-9993: Have basic constraint in CA certificate #2286
CLOUDSTACK-9993: Have basic constraint in CA certificate #2286
Conversation
- Refactors V3 x509 cert generator to put basic constraint and key usage extensions when CA cert is created - Refactors root CA provider to use V3 generator to generate CA cert Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@blueorangutan package |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1133 |
@blueorangutan test |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1560)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests LGTM, there seems to be no failures related to the changes
LGTM, this fixes the basic constraint fix. Additional review requested - @DaanHoogland @nvazquez @mlsorensen and others? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
some reformatting is not fully consistent but that keeps me on my toes ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Thanks @nvazquez @DaanHoogland :) |
extensions when CA cert is created
Pinging for review - @mlsorensen @nvazquez @borisstoyanov @DaanHoogland and others
@blueorangutan package