Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-9993: Have basic constraint in CA certificate #2286

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

rohityadavcloud
Copy link
Member

  • Refactors V3 x509 cert generator to put basic constraint and key usage
    extensions when CA cert is created
  • Refactors root CA provider to use V3 generator to generate CA cert

Pinging for review - @mlsorensen @nvazquez @borisstoyanov @DaanHoogland and others

@blueorangutan package

- Refactors V3 x509 cert generator to put basic constraint and key usage
  extensions when CA cert is created
- Refactors root CA provider to use V3 generator to generate CA cert

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
Copy link
Member Author

Verified CA cert:
screenshot from 2017-10-06 12-03-15

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1133

@rohityadavcloud
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1560)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2286-t1560-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 59 look OK, 3 have error(s)

Test Result Time (s) Test File
test_01_vpc_remote_access_vpn Failure 51.20 test_vpc_vpn.py
test_02_redundant_VPC_default_routes Failure 860.77 test_vpc_redundant.py
test_04_rvpc_privategw_static_routes Failure 332.51 test_privategw_acl.py
test_change_service_offering_for_vm_with_snapshots Skipped 0.00 test_vm_snapshots.py
test_09_copy_delete_template Skipped 0.02 test_templates.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.03 test_staticroles.py
test_11_ss_nfs_version_on_ssvm Skipped 0.02 test_ssvm.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.11 test_primary_storage.py
test_vm_nic_adapter_vmxnet3 Skipped 0.00 test_nic_adapter_type.py
test_nested_virtualization_vmware Skipped 0.00 test_nested_virtualization.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_list_ha_for_host_valid Skipped 0.03 test_hostha_simulator.py
test_list_ha_for_host_invalid Skipped 0.05 test_hostha_simulator.py
test_list_ha_for_host Skipped 0.04 test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider Skipped 0.04 test_hostha_simulator.py
test_hostha_enable_feature_valid Skipped 0.04 test_hostha_simulator.py
test_hostha_disable_feature_valid Skipped 0.05 test_hostha_simulator.py
test_hostha_configure_invalid_provider Skipped 0.03 test_hostha_simulator.py
test_hostha_configure_default_driver Skipped 0.03 test_hostha_simulator.py
test_ha_verify_fsm_recovering Skipped 0.03 test_hostha_simulator.py
test_ha_verify_fsm_fenced Skipped 0.04 test_hostha_simulator.py
test_ha_verify_fsm_degraded Skipped 0.05 test_hostha_simulator.py
test_ha_verify_fsm_available Skipped 0.05 test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership Skipped 0.07 test_hostha_simulator.py
test_ha_list_providers Skipped 0.05 test_hostha_simulator.py
test_ha_enable_feature_invalid Skipped 0.12 test_hostha_simulator.py
test_ha_disable_feature_invalid Skipped 0.04 test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones Skipped 0.05 test_hostha_simulator.py
test_configure_ha_provider_valid Skipped 0.07 test_hostha_simulator.py
test_configure_ha_provider_invalid Skipped 0.05 test_hostha_simulator.py
test_deploy_vgpu_enabled_vm Skipped 0.05 test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support Skipped 0.05 test_deploy_vgpu_enabled_vm.py

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM, there seems to be no failures related to the changes

@rohityadavcloud
Copy link
Member Author

rohityadavcloud commented Oct 9, 2017

LGTM, this fixes the basic constraint fix. Additional review requested - @DaanHoogland @nvazquez @mlsorensen and others?

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
some reformatting is not fully consistent but that keeps me on my toes ;)

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rohityadavcloud
Copy link
Member Author

Thanks @nvazquez @DaanHoogland :)

@rohityadavcloud rohityadavcloud merged commit c3ed1b3 into apache:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants