CLOUDSTACK-9859: Retirement of midonet plugin (final removal) #2285

rafaelweingartner · 2017-10-04T16:43:54Z

Following the component retirement process defined in [1], a vote thread was started in [2]. The community decided to retire the Midonet plugin. This task represents the final step of the retirement, which is the removal of the plugin from CloudStacks code base.

[1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68720798
[2] http://markmail.org/message/qigrtfirwnmct4hr

This closes #CLOUDSTACK-9859

marcaurele · 2017-10-05T05:17:43Z

setup/db/db/schema-41000to41100.sql

@@ -248,3 +248,6 @@ ALTER TABLE `cloud`.`oobm` MODIFY COLUMN port VARCHAR(255);

 -- CLOUDSTACK-9902: Console proxy SSL toggle
 INSERT IGNORE INTO `cloud`.`configuration` (`category`, `instance`, `component`, `name`, `value`, `description`, `default_value`, `is_dynamic`) VALUES ('Console Proxy', 'DEFAULT', 'AgentManager', 'consoleproxy.sslEnabled', 'false', 'Enable SSL for console proxy', 'false', 0);
+
+-- CLOUDSTACK-9859: Retirement of midonet plugin (final removal) 
+delete from `cloud`.`configuration` where name in ('midonet.apiserver.address', 'midonet.providerrouter.id')


Missing ; at the end of the line

What a good pair of eyes!
Thanks!

rohityadavcloud · 2017-10-05T09:35:28Z

LGTM, thanks @rafaelweingartner
@blueorangutan package

blueorangutan · 2017-10-05T09:36:33Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-10-05T10:02:39Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1132

Following the component retirement process defined in [1], a vote thread was started in [2]. The community decided to retire this Midonet plugin. This task represents the final step of the retirement, which is the removal of the plugin from CloudStacks code base. [1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68720798 [2] http://markmail.org/message/qigrtfirwnmct4hr This closes #CLOUDSTACK-9859

rafaelweingartner · 2017-10-05T12:17:10Z

@marcaurele and @rhtyd can you also review this one?
apache/cloudstack-docs#20

We have to reflect this on our docs as well

rohityadavcloud · 2017-10-06T14:25:46Z

@blueorangutan package

blueorangutan · 2017-10-06T14:26:31Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-10-06T14:58:13Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1136

rohityadavcloud · 2017-10-06T15:12:00Z

@blueorangutan test

blueorangutan · 2017-10-06T15:12:31Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-10-07T03:29:50Z

Trillian test result (tid-1562)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44234 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2285-t1562-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 54 look OK, 8 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_remote_access_vpn	`Failure`	45.56	test_vpc_vpn.py
test_05_rvpc_multi_tiers	`Failure`	190.68	test_vpc_redundant.py
test_08_reboot_cpvm	`Failure`	0.02	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.02	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.03	test_ssvm.py
test_02_list_cpvm_vm	`Failure`	0.02	test_ssvm.py
test_01_sys_vm_start	`Failure`	0.05	test_secondary_storage.py
test_04_rvpc_privategw_static_routes	`Failure`	359.18	test_privategw_acl.py
test_08_migrate_vm	`Error`	30.57	test_vm_life_cycle.py
test_10_destroy_cpvm	`Error`	5.12	test_ssvm.py
test_09_destroy_ssvm	`Error`	5.10	test_ssvm.py
test_05_stop_ssvm	`Error`	5.12	test_ssvm.py
test_04_extract_Iso	`Error`	0.07	test_iso.py
ContextSuite context=TestInternalLb>:setup	`Error`	0.00	test_internal_lb.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
test_09_copy_delete_template	Skipped	0.01	test_templates.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.01	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.01	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.05	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_list_ha_for_host_valid	Skipped	0.01	test_hostha_simulator.py
test_list_ha_for_host_invalid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host	Skipped	0.01	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_valid	Skipped	0.01	test_hostha_simulator.py
test_hostha_disable_feature_valid	Skipped	0.01	test_hostha_simulator.py
test_hostha_configure_invalid_provider	Skipped	0.01	test_hostha_simulator.py
test_hostha_configure_default_driver	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_recovering	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_fenced	Skipped	0.01	test_hostha_simulator.py
test_ha_verify_fsm_degraded	Skipped	0.01	test_hostha_simulator.py
test_ha_verify_fsm_available	Skipped	0.01	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	Skipped	0.02	test_hostha_simulator.py
test_ha_list_providers	Skipped	0.02	test_hostha_simulator.py
test_ha_enable_feature_invalid	Skipped	0.01	test_hostha_simulator.py
test_ha_disable_feature_invalid	Skipped	0.01	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	Skipped	0.01	test_hostha_simulator.py
test_configure_ha_provider_valid	Skipped	0.01	test_hostha_simulator.py
test_configure_ha_provider_invalid	Skipped	0.02	test_hostha_simulator.py
test_deploy_vgpu_enabled_vm	Skipped	0.02	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.02	test_deploy_vgpu_enabled_vm.py

rohityadavcloud · 2017-10-09T07:26:03Z

Looks like environment issues, I'll rekick tests.
@blueorangutan test

blueorangutan · 2017-10-09T07:26:32Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-10-09T18:02:54Z

Trillian test result (tid-1565)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34004 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2285-t1565-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 60 look OK, 2 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_remote_access_vpn	`Failure`	55.92	test_vpc_vpn.py
test_04_rvpc_privategw_static_routes	`Failure`	315.83	test_privategw_acl.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
test_09_copy_delete_template	Skipped	0.02	test_templates.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.03	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.09	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_list_ha_for_host_valid	Skipped	0.03	test_hostha_simulator.py
test_list_ha_for_host_invalid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host	Skipped	0.03	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	Skipped	0.05	test_hostha_simulator.py
test_hostha_enable_feature_valid	Skipped	0.03	test_hostha_simulator.py
test_hostha_disable_feature_valid	Skipped	0.03	test_hostha_simulator.py
test_hostha_configure_invalid_provider	Skipped	0.03	test_hostha_simulator.py
test_hostha_configure_default_driver	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_recovering	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_fenced	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_degraded	Skipped	0.03	test_hostha_simulator.py
test_ha_verify_fsm_available	Skipped	0.02	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	Skipped	0.02	test_hostha_simulator.py
test_ha_list_providers	Skipped	0.03	test_hostha_simulator.py
test_ha_enable_feature_invalid	Skipped	0.03	test_hostha_simulator.py
test_ha_disable_feature_invalid	Skipped	0.03	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_valid	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_invalid	Skipped	0.03	test_hostha_simulator.py
test_deploy_vgpu_enabled_vm	Skipped	0.04	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.04	test_deploy_vgpu_enabled_vm.py

rohityadavcloud · 2017-10-10T04:38:11Z

Tests LGTM, will merge now. Thanks @rafaelweingartner

marcaurele requested changes Oct 5, 2017

View reviewed changes

rafaelweingartner force-pushed the CLOUDSTACK-9859 branch from 6b91ec1 to 3a73407 Compare October 5, 2017 09:28

rafaelweingartner force-pushed the CLOUDSTACK-9859 branch from 3a73407 to b4ba7df Compare October 5, 2017 12:03

marcaurele approved these changes Oct 5, 2017

View reviewed changes

rohityadavcloud merged commit b044f1b into apache:master Oct 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLOUDSTACK-9859: Retirement of midonet plugin (final removal) #2285

CLOUDSTACK-9859: Retirement of midonet plugin (final removal) #2285

rafaelweingartner commented Oct 4, 2017 •

edited

Loading

marcaurele Oct 5, 2017

rafaelweingartner Oct 5, 2017

rohityadavcloud commented Oct 5, 2017

blueorangutan commented Oct 5, 2017

blueorangutan commented Oct 5, 2017

rafaelweingartner commented Oct 5, 2017

rohityadavcloud commented Oct 6, 2017

blueorangutan commented Oct 6, 2017

blueorangutan commented Oct 6, 2017

rohityadavcloud commented Oct 6, 2017

blueorangutan commented Oct 6, 2017

blueorangutan commented Oct 7, 2017

rohityadavcloud commented Oct 9, 2017

blueorangutan commented Oct 9, 2017

blueorangutan commented Oct 9, 2017

rohityadavcloud commented Oct 10, 2017

CLOUDSTACK-9859: Retirement of midonet plugin (final removal) #2285

CLOUDSTACK-9859: Retirement of midonet plugin (final removal) #2285

Conversation

rafaelweingartner commented Oct 4, 2017 • edited Loading

marcaurele Oct 5, 2017

Choose a reason for hiding this comment

rafaelweingartner Oct 5, 2017

Choose a reason for hiding this comment

rohityadavcloud commented Oct 5, 2017

blueorangutan commented Oct 5, 2017

blueorangutan commented Oct 5, 2017

rafaelweingartner commented Oct 5, 2017

rohityadavcloud commented Oct 6, 2017

blueorangutan commented Oct 6, 2017

blueorangutan commented Oct 6, 2017

rohityadavcloud commented Oct 6, 2017

blueorangutan commented Oct 6, 2017

blueorangutan commented Oct 7, 2017

rohityadavcloud commented Oct 9, 2017

blueorangutan commented Oct 9, 2017

blueorangutan commented Oct 9, 2017

rohityadavcloud commented Oct 10, 2017

rafaelweingartner commented Oct 4, 2017 •

edited

Loading