Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-10101: Present the full domain name when listing user's domains in SAML2 plugin #2280

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

GabrielBrascher
Copy link
Member

This PR is related to the Saml2 user authentication plugin.

The user can list its domains. His/Her domains are presented as the following example:
username/subdomainA
username/subdomainB

However, if a user has two subdomains of the same name (Dom1/subdomainA and Dom2/subdomainA) the list is presented as follows:
username/subdomainA
username/subdomainA

The proposed change allows showing the full domain name to avoid such cases. Thus, the domains will be presented as follows:
username/Dom1/subdomainA
username/Dom2/subdomainA

This commit is related to the Saml2 user authentication plugin.

The user can list its domains. His/Her domains are presented as the
following example:
username/subdomainA
username/subdomainB

However, if a user has two subdomains of the same name Dom1/subdomainA
and Dom2/subdomainA, the list is presented as follows:
username/subdomainA
username/subdomainA

With this commit it shows the full domain name to avoid such cases.
Thus, the domains will be presented as follows:
username/Dom1/subdomainA
username/Dom2/subdomainA
@GabrielBrascher GabrielBrascher changed the title CLOUDSTACK-10101: Present the full domain name when listing user's domains CLOUDSTACK-10101: Present the full domain name when listing user's domains in SAML2 plugin Oct 1, 2017
@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@rohityadavcloud
Copy link
Member

LGTM, did not test against SAML IdP setup, however I'll help run some regression tests.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1134

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1561)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48597 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2280-t1561-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 59 look OK, 3 have error(s)

Test Result Time (s) Test File
test_01_vpc_remote_access_vpn Failure 81.09 test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn Failure 266.67 test_vpc_vpn.py
test_02_redundant_VPC_default_routes Failure 874.86 test_vpc_redundant.py
test_04_rvpc_privategw_static_routes Failure 372.10 test_privategw_acl.py
test_change_service_offering_for_vm_with_snapshots Skipped 0.01 test_vm_snapshots.py
test_09_copy_delete_template Skipped 0.02 test_templates.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.03 test_staticroles.py
test_11_ss_nfs_version_on_ssvm Skipped 0.02 test_ssvm.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.12 test_primary_storage.py
test_vm_nic_adapter_vmxnet3 Skipped 0.00 test_nic_adapter_type.py
test_nested_virtualization_vmware Skipped 0.00 test_nested_virtualization.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_list_ha_for_host_valid Skipped 0.04 test_hostha_simulator.py
test_list_ha_for_host_invalid Skipped 0.05 test_hostha_simulator.py
test_list_ha_for_host Skipped 0.04 test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider Skipped 0.03 test_hostha_simulator.py
test_hostha_enable_feature_valid Skipped 0.04 test_hostha_simulator.py
test_hostha_disable_feature_valid Skipped 0.04 test_hostha_simulator.py
test_hostha_configure_invalid_provider Skipped 0.04 test_hostha_simulator.py
test_hostha_configure_default_driver Skipped 0.04 test_hostha_simulator.py
test_ha_verify_fsm_recovering Skipped 0.04 test_hostha_simulator.py
test_ha_verify_fsm_fenced Skipped 0.04 test_hostha_simulator.py
test_ha_verify_fsm_degraded Skipped 0.04 test_hostha_simulator.py
test_ha_verify_fsm_available Skipped 0.04 test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership Skipped 0.05 test_hostha_simulator.py
test_ha_list_providers Skipped 0.04 test_hostha_simulator.py
test_ha_enable_feature_invalid Skipped 0.04 test_hostha_simulator.py
test_ha_disable_feature_invalid Skipped 0.04 test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones Skipped 0.04 test_hostha_simulator.py
test_configure_ha_provider_valid Skipped 0.04 test_hostha_simulator.py
test_configure_ha_provider_invalid Skipped 0.04 test_hostha_simulator.py
test_deploy_vgpu_enabled_vm Skipped 0.06 test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support Skipped 0.07 test_deploy_vgpu_enabled_vm.py

@GabrielBrascher
Copy link
Member Author

Thanks @rhtyd!

I have this change in a production environment that uses SAML2.
image

@rohityadavcloud
Copy link
Member

LGTM, test LGTM. Merging now, thanks @GabrielBrascher

@rohityadavcloud rohityadavcloud merged commit f1c01a5 into apache:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants