-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDSTACK-10101: Present the full domain name when listing user's domains in SAML2 plugin #2280
CLOUDSTACK-10101: Present the full domain name when listing user's domains in SAML2 plugin #2280
Conversation
This commit is related to the Saml2 user authentication plugin. The user can list its domains. His/Her domains are presented as the following example: username/subdomainA username/subdomainB However, if a user has two subdomains of the same name Dom1/subdomainA and Dom2/subdomainA, the list is presented as follows: username/subdomainA username/subdomainA With this commit it shows the full domain name to avoid such cases. Thus, the domains will be presented as follows: username/Dom1/subdomainA username/Dom2/subdomainA
@blueorangutan package |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
LGTM, did not test against SAML IdP setup, however I'll help run some regression tests. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1134 |
@blueorangutan test |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1561)
|
Thanks @rhtyd! I have this change in a production environment that uses SAML2. |
LGTM, test LGTM. Merging now, thanks @GabrielBrascher |
This PR is related to the Saml2 user authentication plugin.
The user can list its domains. His/Her domains are presented as the following example:
username/subdomainA
username/subdomainB
However, if a user has two subdomains of the same name (Dom1/subdomainA and Dom2/subdomainA) the list is presented as follows:
username/subdomainA
username/subdomainA
The proposed change allows showing the full domain name to avoid such cases. Thus, the domains will be presented as follows:
username/Dom1/subdomainA
username/Dom2/subdomainA