CLOUDSTACK-10099 #2277
Merged
CLOUDSTACK-10099 #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM, can we have some screenshots or UI confirmations (like before/after fix)? |
|
LGTM |
|
The GUI looks identical.
From a behavioral standpoint, an error message is no longer displayed after the migration attempt because the migration reports success.
On Sep 29, 2017, at 12:30 AM, Rohit Yadav <notifications@github.com<mailto:notifications@github.com>> wrote:
LGTM, can we have some screenshots or UI confirmations (like before/after fix)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2277 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SH4wqfrumkW6jXrbXg-Ox-WIWrRIiks5snI5ygaJpZM4PoOTM>.
|
|
Fair enough, LGTM. Merging based on core review, since it's UI change no other integration tests are requested. Travis is okay, the one failing test is a known intermittent failure, ignorable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for CLOUDSTACK-10099, which concerns the GUI not invoking the migrateVirtualMachineWithVolume API command when it should.