Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-10007 Isolation method claim #2249

Merged
merged 3 commits into from
Sep 28, 2017

Conversation

DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Aug 28, 2017

This will prevent DirectNetworkGuru from designing and implementing a network it is not supposed to but, as discussed with @fmaximus, the commit "remove hardcoded exemptions on directnetworkguru" will still allow it to implement a network if it supports one of the services from the offering so several gurus can still end up implementing a single network.
Solutions could include:

  • only canHandle() if all required services are supported
  • link a guru to a physical network and not ask for any guru if they canHandle()
  • retrospecively check what guru implements the best set of services.

@DaanHoogland DaanHoogland requested a review from nvazquez August 28, 2017 08:12
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rohityadavcloud
Copy link
Member

LGTM.

@DaanHoogland DaanHoogland changed the title CLOUDSTACK-10007 Isolation method claim WIP CLOUDSTACK-10007 Isolation method claim Aug 30, 2017
@DaanHoogland
Copy link
Contributor Author

for now revert the last commit (see description).

@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1109

@DaanHoogland
Copy link
Contributor Author

@blueorangutan matrix

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland DaanHoogland changed the title WIP CLOUDSTACK-10007 Isolation method claim CLOUDSTACK-10007 Isolation method claim Sep 27, 2017
@blueorangutan
Copy link

Trillian test result (tid-1541)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39653 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2249-t1541-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 60 look OK, 2 have error(s)

Test Result Time (s) Test File
test_01_vpc_remote_access_vpn Failure 60.93 test_vpc_vpn.py
test_04_rvpc_privategw_static_routes Failure 482.06 test_privategw_acl.py
test_change_service_offering_for_vm_with_snapshots Skipped 0.00 test_vm_snapshots.py
test_09_copy_delete_template Skipped 0.02 test_templates.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.02 test_staticroles.py
test_11_ss_nfs_version_on_ssvm Skipped 0.02 test_ssvm.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.09 test_primary_storage.py
test_vm_nic_adapter_vmxnet3 Skipped 0.00 test_nic_adapter_type.py
test_nested_virtualization_vmware Skipped 0.00 test_nested_virtualization.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_list_ha_for_host_valid Skipped 0.02 test_hostha_simulator.py
test_list_ha_for_host_invalid Skipped 0.02 test_hostha_simulator.py
test_list_ha_for_host Skipped 0.02 test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider Skipped 0.03 test_hostha_simulator.py
test_hostha_enable_feature_valid Skipped 0.04 test_hostha_simulator.py
test_hostha_disable_feature_valid Skipped 0.03 test_hostha_simulator.py
test_hostha_configure_invalid_provider Skipped 0.02 test_hostha_simulator.py
test_hostha_configure_default_driver Skipped 0.03 test_hostha_simulator.py
test_ha_verify_fsm_recovering Skipped 0.03 test_hostha_simulator.py
test_ha_verify_fsm_fenced Skipped 0.02 test_hostha_simulator.py
test_ha_verify_fsm_degraded Skipped 0.03 test_hostha_simulator.py
test_ha_verify_fsm_available Skipped 0.02 test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership Skipped 0.02 test_hostha_simulator.py
test_ha_list_providers Skipped 0.02 test_hostha_simulator.py
test_ha_enable_feature_invalid Skipped 0.02 test_hostha_simulator.py
test_ha_disable_feature_invalid Skipped 0.02 test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones Skipped 0.02 test_hostha_simulator.py
test_configure_ha_provider_valid Skipped 0.02 test_hostha_simulator.py
test_configure_ha_provider_invalid Skipped 0.03 test_hostha_simulator.py
test_deploy_vgpu_enabled_vm Skipped 0.03 test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support Skipped 0.04 test_deploy_vgpu_enabled_vm.py

@DaanHoogland DaanHoogland merged commit a06530d into apache:master Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants