CLOUDSTACK-10019:template.properties has hardcoded id

[mrunalinikankariya]

template.properties file created after creating template from snapshot has hardcoded id = 1

id should have templateId

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-999

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1016

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1413)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31167 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2243-t1413-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 54 look OK, 3 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_remote_access_vpn	Failure	55.89	test_vpc_vpn.py
test_04_rvpc_privategw_static_routes	Failure	311.09	test_privategw_acl.py
test_05_iso_permissions	Failure	0.06	test_iso.py
test_02_edit_iso	Failure	0.05	test_iso.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
test_09_copy_delete_template	Skipped	0.02	test_templates.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.02	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.03	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.04	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_deploy_vgpu_enabled_vm	Skipped	0.03	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.03	test_deploy_vgpu_enabled_vm.py

[mrunalinikankariya]

Test failure doesn't seem to be relevant to the change for this ticket

[rohityadavcloud]

@mrunalinikankariya can you check and fix the errors, are issues around iso permissions (public or not) should not happen, the test failed twice.
@blueorangutan test centos7 vmware-55u3

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1419)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42493 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2243-t1419-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 52 look OK, 5 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_remote_access_vpn	Failure	166.79	test_vpc_vpn.py
test_01_create_volume	Failure	190.04	test_volumes.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	Failure	407.76	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	Failure	442.30	test_routers_network_ops.py
test_04_rvpc_privategw_static_routes	Failure	763.52	test_privategw_acl.py
test_05_iso_permissions	Failure	0.07	test_iso.py
test_02_edit_iso	Failure	0.08	test_iso.py
test_08_resize_volume	Skipped	5.11	test_volumes.py
test_07_resize_fail	Skipped	10.27	test_volumes.py
test_09_copy_delete_template	Skipped	0.02	test_templates.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.03	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	34.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.04	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_06_verify_guest_lspci_again	Skipped	0.00	test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restart	Skipped	0.00	test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci	Skipped	0.00	test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_disk	Skipped	0.00	test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restart	Skipped	0.00	test_deploy_virtio_scsi_vm.py
test_01_verify_libvirt	Skipped	0.00	test_deploy_virtio_scsi_vm.py
test_deploy_vgpu_enabled_vm	Skipped	1.23	test_deploy_vgpu_enabled_vm.py

[rohityadavcloud]

Iso related errors are seen please check @mrunalinikankariya

[mrunalinikankariya]

These error are not related to the fix

[rohityadavcloud]

alright @mrunalinikankariya I'll compare against #2225 and merge if there are no regressions

[cloudmonger]

ACS CI BVT Run

Sumarry:
Build Number 1152
Hypervisor xenserver
NetworkType Advanced
Passed=109
Failed=5
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

• test_router_dns.py

• test_router_dns_guestipquery Failed

• test_routers_network_ops.py

• test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 17 runs

• test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 144 runs

• test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 139 runs

• test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 139 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_router_dnsservice.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

[SudharmaJain]

@mrunalinikankariya Your bug descriptions are not clear. Could you put clear descriptions as what is the actual issue you are facing and how does this fix resolves the issue.

[SowjanyaPatha]

LGTM for Testing. Checked for the ID value.
Before Fix:

After Fix:

[SudharmaJain]

@SowjanyaPatha Once @mrunalinikankariya updates the description with the exact issue. Please test the scenario again.

[rohityadavcloud]

LGTM.