Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID #2238

Merged
merged 1 commit into from
Nov 2, 2017
Merged

[CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID #2238

merged 1 commit into from
Nov 2, 2017
+3,125 −449

Conversation

fmaximus
Copy link
Contributor

@fmaximus fmaximus commented Aug 16, 2017 •
edited
Loading

  • VSP Id caching
  • VSP request statistics
  • VSP 5.0 support

@fmaximus fmaximus force-pushed the feature/caching_and_statistics branch from 5c5d8b4 to ca57305 Compare August 16, 2017 12:26
borisstoyanov
borisstoyanov reviewed Aug 17, 2017
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fmaximus, can you please add a community jira for these improvements

@fmaximus fmaximus changed the title Performance improvement: caching of NuageVsp ID [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID Aug 21, 2017
@fmaximus
Copy link
Contributor Author

CLOUDSTACK-10053

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1083

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@sgoeminn sgoeminn force-pushed the feature/caching_and_statistics branch from ca57305 to 7f911ba Compare October 11, 2017 12:36
@sgoeminn sgoeminn force-pushed the feature/caching_and_statistics branch from 7f911ba to a659409 Compare October 23, 2017 14:57
smeetsr
smeetsr approved these changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@smeetsr smeetsr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executed all regressions for this PR without failures. Approving.

@sgoeminn
Copy link
Contributor

CI failure seems not to be related to this PR (known issue).

@fmaximus @smeetsr
CLOUDSTACK-10053: Performance improvement: caching of NuageVsp ID
0871ff9 
* VSP ID Caching
* VSP call Statistics
* 5.0 Support

Co-Authored-By: Frank Maximus <frank.maximus@nuagenetworks.net>
Co-Authored-By: Raf Smeets <raf.smeets@nuagenetworks.net>
@fmaximus fmaximus force-pushed the feature/caching_and_statistics branch from a659409 to 0871ff9 Compare October 31, 2017 16:06
@fmaximus fmaximus added this to the 4.11 milestone Oct 31, 2017
krissterckx
krissterckx approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@krissterckx krissterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmaximus fmaximus merged commit 2139dbe into apache:master Nov 2, 2017
@rohityadavcloud
Copy link
Member

@fmaximus looks like Trillian job failed to complete regression testing. Kindly don't merge PRs that don't have regression testing from at least one of the hypervisors. Travis tests while useful aren't as comprehensive as only those tests run that don't require real hardware, several of the networking, storage tests are simply skipped. I suppose this works with Nuage, I'll kick regression smoke tests on #2225 soon.

@fmaximus
Copy link
Contributor Author

fmaximus commented Nov 8, 2017

@rhtyd We ran regression tests on our infrastructure (centos7 mgmt + 2 computes: kvm-centos7-nuage)

borisstoyanov
borisstoyanov reviewed Nov 8, 2017
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmaximus we don't have nuage images in trillian, what we can do though is to run regular kvm hosts on centos7, would that be OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisstoyanov borisstoyanov borisstoyanov left review comments

@krissterckx krissterckx krissterckx approved these changes

@smeetsr smeetsr smeetsr approved these changes

Assignees
No one assigned
Labels
component:plugin type:enhancement
Projects
None yet
Milestone
4.11.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@fmaximus @rohityadavcloud @blueorangutan @sgoeminn @krissterckx @borisstoyanov @smeetsr