Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, change version to 4.9.1.0-SNAPSHOT #1646

Merged
merged 2 commits into from
Aug 23, 2016

Conversation

rohityadavcloud
Copy link
Member

This adds db upgrade path from 4.9.0 to 4.9.1 and fixes a typo in default user role description (CLOUDSTACK-9449)

/cc @karuturi @jburwell -- this will cause issues when fwd-merged to master, I can do the fwd-merging if you would like to avoid fixing the conflicts yourself

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1646
Job ID-90

@jburwell
Copy link
Contributor

jburwell commented Aug 18, 2016

@rhtyd we are moving to four position to version numbers to support our recent security release change where the fourth position is used to reflect security patch. Therefore, the release schedule designates the next release as 4.9.1.0. Could you please update the POMs to reflect the fourth position? We also need this change made for master (4.10.0.0) and 4.8 (4.8.2.0).

@rohityadavcloud
Copy link
Member Author

@jburwell this makes sense, I'll update the PR and also fix this on master. Regarding 4.8 branch, I'm not sure so I'll ask @swill -- Will can you run setnextversion.sh on 4.8 branch to say 4.8.3.0-SNAPSHOT ?

- Adds db upgrade path from 4.9.0 to 4.9.1
- CLOUDSTACK-9449: Fix typo in default user role description

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
Copy link
Member Author

@jburwell @karuturi fixed.

@rohityadavcloud rohityadavcloud changed the title [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1 [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, change version to 4.9.1.0-SNAPSHOT Aug 19, 2016
@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1646
Job ID-91

@jburwell
Copy link
Contributor

@rhtyd could you please squash the commits?

@rohityadavcloud
Copy link
Member Author

@jburwell I've kept the changes into two commits (1) for pom.xml related version changes and (2) for db upgrade path, as when doing fwd-merging this will cause conflict with other pom files so on fwd-merging we can use a merging strategy to pick changes on (ours) master for the pom related changes while take the db upgrade path changes. I'll further require to fix the upgrade path on master branch to be like --> 4.9.0->4.9.1(.0)->4.10.0(.0) which is right now set as 4.9.0->4.10.0. I can also help with doing the fwd-merging so you can avoid dealing with the conflicts yourself.

@jburwell
Copy link
Contributor

jburwell commented Aug 23, 2016

@rhtyd I understand the reasoning for two commits, and it makes sense. Since you understand the process required for the forward merge, I think it makes sense for you to perform it.

LGTM for code.

This PR is a blocker for cutting the 4.9.1.0 release candidate. @karuturi @swill @wido are you able to provide a test LGTM? blueorangutan built packages successfully. I think simply doing a mvn clean install -P systemvm,developer -Dnoredist, and checking that JARs have a -4.9.1.0-SNAPSHOT suffix would be sufficient to verify this change. Do y'all agree?

@karuturi
Copy link
Member

code LGTM

@rohityadavcloud
Copy link
Member Author

@jburwell yes that and we can also verify from packages that the version is reflected in the pkg names.

@rohityadavcloud
Copy link
Member Author

rohityadavcloud commented Aug 23, 2016

Given we've enough reviews and tests (Travis) passing, I'll go ahead merge this and merge this fwd to master.

@asfgit asfgit merged commit f13c224 into apache:4.9 Aug 23, 2016
asfgit pushed a commit that referenced this pull request Aug 23, 2016
[4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, change version to 4.9.1.0-SNAPSHOTThis adds db upgrade path from 4.9.0 to 4.9.1 and fixes a typo in default user role description (CLOUDSTACK-9449)

/cc @karuturi @jburwell  -- this will cause issues when fwd-merged to master, I can do the fwd-merging if you would like to avoid fixing the conflicts yourself

@blueorangutan package

* pr/1646:
  Updating pom.xml version numbers for release 4.9.1.0-SNAPSHOT
  cloudstack: upgrade path from 4.9.0 to 4.9.1

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1646
Job ID-100

@rohityadavcloud
Copy link
Member Author

Fwd-merged this to master, with db version on master fixed during merge conflict to 4.10.0.0-SNAPSHOT, and db paths fixed as 4.9.0->4.9.1->4.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants