4.9 mvn version safeupgradeonly #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated most dependencies to latest minor releases, EXCEPT: - Gson 2.x - Major spring framework version - Servlet version - Embedded jetty version - Mockito version (beta) - Mysql lib minor version upgrade (breaks mysql-ha plugin) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Fixes enum name to supress checkstyle failure due to the latest checkstyle version Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
- Fix jetty dependency that is compatible with Java7 - Upgrade minor revisions of dependencies - Upgrade vmware mvn sdk dependency to 6.0 - Downgrade bounty castle version to 1.46 (same as before) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
With this change we would be able to use JDK8 for building cloudstack once we fix the build issues of F5 plugin (that's the only component that fails to build with javac 1.8 now). |
|
@swill please include this PR in your list, thanks |
|
@bhaisaab yep, already got it. 👍 |
|
@swill busy on this one yet? I am looking to run it as well |
|
go ahead. I am trying to get to the bottom of marvin being strange right now. |
|
@swill thanks, this can be merged first as we wait for bountycastle related changes to work with openjdk 1.7.0_95+ |
CI RESULTSAssociated Uploads
Uploads will be available until Comment created by |
|
This one is ready pending at least one LGTM code review... |
|
@DaanHoogland @wido @jburwell review/lgtm please? |
|
Compiled the code using JDK8 (1.8.0_65) and ran unit tests, works on my system. Based on the code changes: LGTM |
|
LGTM, i had run the tests as well, with no more then the usual problems &*%(^%. Note that part of the change is mine when you take my lgtm for it;) |
|
Thank you gentlemen. I think this one is ready now. 👍 |
asfgit
pushed a commit
that referenced
this pull request
Apr 28, 2016
4.9 mvn version safeupgradeonlyUpgrades maven dependencies versions that can be safely upgraded without breaking console-proxy/crypto usage. Bisected changes from: #1397 cc @swill @DaanHoogland * pr/1510: maven: fix dependency version support by JDK7 further maven dependency updates from Daan framework/quota: fix checkstyle issue maven: Upgrade dependency versions Signed-off-by: Will Stevens <williamstevens@gmail.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Nov 30, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Nov 30, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Nov 30, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Nov 30, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Nov 30, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Dec 1, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Dec 1, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Fixes servlet issue, uses servlet 3.1.0 - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Dec 2, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Fixes servlet issue, uses servlet 3.1.0 - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Dec 2, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Fixes servlet issue, uses servlet 3.1.0 - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Dec 6, 2016
- Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning - Fixes servlet issue, uses servlet 3.1.0 - Downgrade javassist used by reflections to fix annotation process errors - Make console-proxy-rdp bc dependency same as rest of the codebase - Picks up PR apache#1510 by Daan Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades maven dependencies versions that can be safely upgraded without breaking console-proxy/crypto usage.
Bisected changes from: #1397
cc @swill @DaanHoogland