Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick commits related to recent RESGROUP v2 merge. #579

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

reshke
Copy link
Contributor

@reshke reshke commented Aug 20, 2024

without this, it compiles with errors.


cgroup_io_limit.c: In function ‘get_bdi_of_path’:
cgroup_io_limit.c:265:2: error: ignoring return value of ‘realpath’, declared with attribute warn_unused_result [-Werror=unused-result]
  (void)realpath(sysfs_path, real_path);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cgroup_io_limit.c:280:2: error: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Werror=unused-result]
  (void)fscanf(f, "%d:%d", &parent_maj, &parent_min);

higuoxing and others added 2 commits August 20, 2024 09:33
…#16011)

These files are generated by parser generator, let's ignore them.
This commit fixes following warnings:
+ "unused" warnings are caused by the token type (keyword type are
declared to be value type).

+ result of "realpath" and "fscanf" not be handled.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@my-ship-it my-ship-it assigned jiaqizho and unassigned jiaqizho Aug 21, 2024
@my-ship-it my-ship-it requested a review from jiaqizho August 21, 2024 01:32
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@avamingli avamingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help.

@avamingli avamingli merged commit e07ebf5 into apache:main Aug 21, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants