Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support distributed by clause specification when Create MV if not exists #563

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

reshke
Copy link
Contributor

@reshke reshke commented Aug 8, 2024

$subj

For some reason, current grammatical parser does not accept Distributed By clause in case IF NOT EXISTS specified for materialized view, which I don't any any reason to disallow

@reshke
Copy link
Contributor Author

reshke commented Aug 8, 2024

hmmm icw-test are failing, but they look unrelated to C.M.V, aren't they?

@avamingli
Copy link
Contributor

Hi, please provide cases to verify what you have done.

@reshke
Copy link
Contributor Author

reshke commented Aug 8, 2024

Hi, please provide cases to verify what you have done.

Hi, you mean some regression test-cases? They are as obvious as

create table t1(i int);
create materialized view if not exists mv1 as select i from t1 distributed by (i);

(this fails on current HEAD)

I dont think we need anything more complicated here.

Will do

@reshke
Copy link
Contributor Author

reshke commented Aug 9, 2024

Seems that matview_optimizer.out depends on matview tests. Pushed commit should fix test

@reshke
Copy link
Contributor Author

reshke commented Aug 16, 2024

Are there any open items/suggestion/issues?

@my-ship-it my-ship-it merged commit 978bab5 into apache:main Aug 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants