Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the resgroup test cases in CI #539

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jiaqizho
Copy link
Contributor

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@jiaqizho jiaqizho force-pushed the enable-resgroup-test-cases branch 2 times, most recently from 9166776 to 9bbf899 Compare July 30, 2024 05:31
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Aug 14, 2024

will rebase this pr after #531 merged

@jiaqizho jiaqizho force-pushed the enable-resgroup-test-cases branch from 9bbf899 to 97aa3a4 Compare August 26, 2024 09:30
@jiaqizho jiaqizho changed the title [DNM]Enable the resgroup test cases Enable the resgroup test cases in CI Aug 26, 2024
@jiaqizho
Copy link
Contributor Author

no sure why no exec the prepare_resgroup, let me check

@jiaqizho jiaqizho force-pushed the enable-resgroup-test-cases branch 2 times, most recently from 85b11a0 to 3a80f8c Compare August 28, 2024 12:55
@jiaqizho jiaqizho force-pushed the enable-resgroup-test-cases branch from 3a80f8c to 3c966f0 Compare August 28, 2024 13:55
@my-ship-it my-ship-it merged commit c711df8 into apache:main Aug 29, 2024
12 checks passed
@tuhaihe
Copy link
Member

tuhaihe commented Aug 29, 2024

FYI: I also added this new icw-resgroup-test as one required check for the pull request merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants