Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cbdb ci not running properly #497

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Baowen648
Copy link
Contributor

@Baowen648 Baowen648 commented Jul 4, 2024

fix #ISSUE_Number


Change logs

On June 30th 2024, Github changed the default from Node16 to Node20.
To opt out of this and continue using Node16 while it is still available
in the runner, we can choose to
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@Baowen648 Baowen648 force-pushed the fix_cbdb-node-env branch from 6c5cbd5 to ff0888d Compare July 4, 2024 08:51
@Baowen648 Baowen648 changed the title fix node16 unwork Fix cbdb ci not running properly Jul 4, 2024
@Baowen648 Baowen648 force-pushed the fix_cbdb-node-env branch from ff0888d to bb037c0 Compare July 4, 2024 08:55
On June 30th 2024, Github change the default from Node16 to Node20.
To opt out of this and continue using Node16 while it is still available
in the runner, you can choose to
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true
@Baowen648 Baowen648 force-pushed the fix_cbdb-node-env branch from bb037c0 to 58543c6 Compare July 4, 2024 11:16
@my-ship-it my-ship-it merged commit 63371e6 into apache:main Jul 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants