Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the correct size of memory block in bitmapinsert #495

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

gfphoenix78
Copy link
Contributor

The field hwords of BMTIDBuffer is a fixed array, not variable.


How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Copy link
Contributor

@avamingli avamingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The field `hwords` of BMTIDBuffer is a fixed array, not variable.
@gfphoenix78 gfphoenix78 merged commit d68aede into apache:main Jul 8, 2024
10 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Sep 20, 2024
The field `hwords` of BMTIDBuffer is a fixed array, not variable.

(cherry picked from commit d68aede)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants