Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the location of python-dependencies.txt #460

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Baowen648
Copy link
Contributor

The Python-dependencies.txt file has been relocated, so the script invocation points need to be adjusted for the scripts to work effectively.

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@Baowen648 Baowen648 force-pushed the change_shell_location branch from fb92c6b to 42e8235 Compare June 5, 2024 09:08
@Baowen648 Baowen648 changed the title Modify the position of Python-dependencies.txt Update the location of python-dependencies.txt Jun 5, 2024
@Baowen648 Baowen648 force-pushed the change_shell_location branch from 42e8235 to 0c76223 Compare June 5, 2024 09:12
@tuhaihe tuhaihe self-requested a review June 5, 2024 10:06
Copy link
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tuhaihe tuhaihe merged commit d2c2d31 into apache:main Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants