Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-842]implement CarbonRowDataWriterProcessorStepImpl for no SORT_COLUMN #741

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-842]implement CarbonRowDataWriterProcessorStepImpl for no SORT_COLUMN #741

wants to merge 1 commit into from

Conversation

QiangCai
Copy link
Contributor

@QiangCai QiangCai commented Apr 5, 2017 •
edited
Loading

When SORT_COLUMNS is empty, the table is unsorted.
For unsorted table:

  1. remove NoSortProcessorStepImpl
  2. implement CarbonRowDataWriterProcessorStepImpl

@asfbot
Copy link

asfbot commented Apr 5, 2017

Can one of the admins verify this patch?

2 similar comments
@asfbot
Copy link

asfbot commented Apr 5, 2017

Can one of the admins verify this patch?

@asfbot
Copy link

asfbot commented Apr 5, 2017

Can one of the admins verify this patch?

@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1454/

@jackylk
Copy link
Contributor

jackylk commented Apr 6, 2017

Are you merging the sort step and write step in this PR?
I think it is better to merge the row transform part from sort step into write step only, and still have an independent sort step, which is optional. This will be more flexible, different sorter can be replaced independently.

@QiangCai QiangCai changed the title [CARBONDATA-782]implement NoSortDataWriterProcessorStepImpl for no SORT_COLUMN [CARBONDATA-782]implement CarbonRowDataWriterProcessorStepImpl for no SORT_COLUMN Apr 6, 2017
@CarbonDataQA
Copy link

Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1458/

@QiangCai QiangCai changed the title [CARBONDATA-782]implement CarbonRowDataWriterProcessorStepImpl for no SORT_COLUMN [CARBONDATA-842]implement CarbonRowDataWriterProcessorStepImpl for no SORT_COLUMN Apr 6, 2017
@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1465/

@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1497/

@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1501/

asfgit pushed a commit that referenced this pull request Apr 7, 2017
@jackylk
[CARBONDATA-842]implement CarbonRowDataWriterProcessorStepImpl for no…
12bf455 
… SORT_COLUMN This closes #741
@jackylk
Copy link
Contributor

jackylk commented Apr 7, 2017

LGTM

@QiangCai QiangCai closed this Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QiangCai @asfbot @CarbonDataQA @jackylk