[CARBONDATA-861] Improvements in query #709
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1380/ |
12af0f8 to
f8607a3
Compare
| @@ -306,6 +307,8 @@ object CompareTest { | |||
| // do GC and sleep for some time before running next table | |||
| System.gc() | |||
| Thread.sleep(1000) | |||
| System.gc() | |||
There was a problem hiding this comment.
There is no guarntee that GC will be called after calling of System.gc(), thats why after waiting for 1 second called again to increase the probability of running GC
| } else { | ||
| "" | ||
| } | ||
| ) | ||
| if (property.nonEmpty && property.charAt(property.length-1) == ',') { | ||
| property = property.replace(property.length-1, property.length, "") |
There was a problem hiding this comment.
change property.length-1 to property.length - 1
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1461/ |
|
@ravipesala please rebase |
b593705 to
579b50f
Compare
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1560/ |
|
LGTM |
Following are the list of improvements done in this part of PR.