Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-278] IS NULL and IS NOT NULL shall be push down to carbon #202

Closed

Conversation

sujith71955
Copy link
Contributor

@sujith71955 sujith71955 commented Sep 27, 2016

Current design : As per the current design IS NULL and IS NOT NULL filter is been handled by spark layer
Drawback : Block/Blocklet level pruning will not be possible if the filter is been processed by spark layer
Proposed Improvement: IS NULL and IS NOT NULL shall be push down to carbon layer since carbon layer can process these filters faster using block/block-let pruning , also while processing filters in executers carbon is applying binary search for applying filter values.

UT/FT Testcases : Existing testcases can verify the impact of this PR change since its not new usecase/scenario.

@sujith71955 sujith71955 force-pushed the master_filterOptimizations branch 2 times, most recently from 59dbc0a to 913f6b0 Compare September 28, 2016 08:45
… layer since carbon layer can process these filters faster using block/block-let pruning ,

 also while processing filters in executors carbon is applying binary search for applying filter values.
@sujith71955
Copy link
Contributor Author

Please find the PR builder status
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/355/

@jackylk
Copy link
Contributor

jackylk commented Oct 12, 2016

@sujith71955 can you add testcase also?

@sujith71955
Copy link
Contributor Author

@jacky Existing testcases can verify the impact of this PR change since its not new usecase/scenario.
There are test cases for IS NULL and IS NOT NULL in the following test classes FilterProcessorTestcase.scala , AllDataTypesTestCaseAggregate.scala. please let me know if i need to add more. Thanks for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants