Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GitHub pull request template #6995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesnetherton
Copy link
Contributor

Not sure what others think. From my POV the PR template generates pointless noise.

@aldettinger
Copy link
Contributor

No strong advice. It may be handy for new contributors so that old contributors won't need to explain ;)
Maybe a few infos would at least deserve to be stored in contributor guide ?

An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
 Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants