Skip to content

Commit

Permalink
Disable Micrometer JMX tests due to #6984
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesnetherton committed Feb 7, 2025
1 parent 9bdc1a0 commit d0d5b3d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 12 deletions.
2 changes: 2 additions & 0 deletions integration-tests/micrometer/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,12 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-jsonb</artifactId>
</dependency>
<!-- TODO: https://github.com/apache/camel-quarkus/issues/6984
<dependency>
<groupId>io.quarkiverse.micrometer.registry</groupId>
<artifactId>quarkus-micrometer-registry-jmx</artifactId>
</dependency>
-->
<!-- test dependencies -->
<dependency>
<groupId>io.quarkus</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,31 +18,26 @@

import java.util.List;

import io.micrometer.core.instrument.Clock;
import io.micrometer.core.instrument.Meter;
import io.micrometer.core.instrument.MeterRegistry;
import io.micrometer.core.instrument.Tag;
import io.micrometer.core.instrument.config.MeterFilter;
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
import io.micrometer.core.instrument.util.HierarchicalNameMapper;
import io.micrometer.jmx.JmxMeterRegistry;
import io.micrometer.prometheus.PrometheusMeterRegistry;
import io.quarkus.arc.profile.IfBuildProfile;
import io.quarkus.micrometer.runtime.MeterFilterConstraint;
import jakarta.enterprise.inject.Produces;
import jakarta.inject.Named;
import jakarta.inject.Singleton;
import org.apache.camel.component.micrometer.CamelJmxConfig;
import org.apache.camel.component.micrometer.MicrometerComponent;

public class MicrometerProducers {

@Produces
@Singleton
@IfBuildProfile("test")
public MeterRegistry registry() {
return new JmxMeterRegistry(CamelJmxConfig.DEFAULT, Clock.SYSTEM, HierarchicalNameMapper.DEFAULT);
}
// TODO: https://github.com/apache/camel-quarkus/issues/6984
// @Produces
// @Singleton
// @IfBuildProfile("test")
// public MeterRegistry registry() {
// return new JmxMeterRegistry(CamelJmxConfig.DEFAULT, Clock.SYSTEM, HierarchicalNameMapper.DEFAULT);
// }

@Produces
@Singleton
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import io.restassured.path.json.JsonPath;
import org.awaitility.Awaitility;
import org.hamcrest.Matchers;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
Expand Down Expand Up @@ -210,6 +211,7 @@ public void testDumpAsJson() {
Matchers.is("1"));
}

@Disabled("https://github.com/apache/camel-quarkus/issues/6984")
@ParameterizedTest
@ValueSource(strings = { "metrics", "org.apache.camel.micrometer" }) //test uses domains from both default and custom JMX registries
@DisabledOnIntegrationTest("https://github.com/apache/camel-quarkus/issues/5209")
Expand Down

0 comments on commit d0d5b3d

Please sign in to comment.