Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install venv dependencies in local env setup #24461

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Dec 1, 2022

These are needed for setting up a virtual environment in various python versions. Right now, not having them can cause our local environment setup actions to fail, this fixes that problem. It also ensures that Python 3.8 is installed since that is the version we use by default (it seems like that version may have been removed from the runner images)

Fixes #24460


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor Author

damccorm commented Dec 1, 2022

R: @AnandInguva

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm damccorm merged commit d93a0d9 into master Dec 1, 2022
@damccorm damccorm deleted the users/damccorm/venv branch December 1, 2022 16:14
@damccorm damccorm mentioned this pull request Dec 1, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Local environment tests failing on GHA
2 participants