Migrate examples and maven-archetypes (including Java Quickstart) to Spark 3 runner #23730
Conversation
…Spark 3 (addresses apache#23728)
Codecov Report
@@ Coverage Diff @@
## master #23730 +/- ##
==========================================
- Coverage 73.24% 73.17% -0.07%
==========================================
Files 719 720 +1
Lines 95955 96062 +107
==========================================
+ Hits 70279 70291 +12
- Misses 24364 24459 +95
Partials 1312 1312
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Run Python PreCommit |
|
R: @ibzib |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Run Java Examples_Spark |
| @@ -109,13 +109,8 @@ dependencies { | |||
| } | |||
| directRunnerPreCommit project(path: ":runners:direct-java", configuration: "shadow") | |||
| flinkRunnerPreCommit project(":runners:flink:${project.ext.latestFlinkVersion}") | |||
| // TODO: Make the netty version used configurable, we add netty-all 4.1.17.Final so it appears on the classpath | |||
| // before 4.1.8.Final defined by Apache Beam | |||
| sparkRunnerPreCommit "io.netty:netty-all:4.1.17.Final" | |||
There was a problem hiding this comment.
Why it was removed as well? Spark2 specific?
There was a problem hiding this comment.
This is far obsolete and has no effect ...
|
Thanks @aromanenko-dev |
…Spark 3 (addresses apache#23728) (apache#23730)
Migrate examples and maven-archetypes (including Java Quickstart) to Spark 3 runner to prepare for removal of Spark 2 runner (#23728).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.