Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-223: Do not link against libpython #95

Closed
wants to merge 1 commit into from
Closed

ARROW-223: Do not link against libpython #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/cmake_modules/FindPythonLibsNew.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,11 @@ FUNCTION(PYTHON_ADD_MODULE _NAME )
SET_TARGET_PROPERTIES(${_NAME} PROPERTIES LINK_FLAGS
"-undefined dynamic_lookup")
ELSE()
TARGET_LINK_LIBRARIES(${_NAME} ${PYTHON_LIBRARIES})
# In general, we should not link against libpython as we do not embed
# the Python interpreter. The python binary itself can then define where
# the symbols should loaded from.
SET_TARGET_PROPERTIES(${_NAME} PROPERTIES LINK_FLAGS
"-Wl,-undefined,dynamic_lookup")
ENDIF()
IF(PYTHON_MODULE_${_NAME}_BUILD_SHARED)
SET_TARGET_PROPERTIES(${_NAME} PROPERTIES PREFIX "${PYTHON_MODULE_PREFIX}")
Expand Down
1 change: 0 additions & 1 deletion python/cmake_modules/UseCython.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ function( cython_add_module _name pyx_target_name generated_files)
include_directories( ${PYTHON_INCLUDE_DIRS} )
python_add_module( ${_name} ${_generated_files} ${other_module_sources} )
add_dependencies( ${_name} ${pyx_target_name})
target_link_libraries( ${_name} ${PYTHON_LIBRARIES} )
endfunction()

include( CMakeParseArguments )