-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45572: [C++][Compute] Add rank_normal function #45573
Conversation
|
@zanmato1984 @WillAyd Does either of you want to take a look at this? |
f671856
to
21315d9
Compare
@github-actions crossbow submit -g cpp |
Revision: 21315d9 Submitted crossbow builds: ursacomputing/crossbow @ actions-77243e4960 |
21315d9
to
50b0a66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
50b0a66
to
c23cebd
Compare
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f9283d0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
Computing ranks as values of the "probit" function (https://en.wikipedia.org/wiki/Probit), rather than quantiles between 0 and 1, can be useful for machine learning and other tasks.
What changes are included in this PR?
Add a "rank_normal" function that computes array ranks as points on the normal distribution.
It is similar to calling the "rank_quantile" function and then applying the normal percent-point function ("probit").
Are these changes tested?
Yes, by dedicated unit tests.
Are there any user-facing changes?
No, except a new compute function.