Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45572: [C++][Compute] Add rank_normal function #45573

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Feb 19, 2025

Rationale for this change

Computing ranks as values of the "probit" function (https://en.wikipedia.org/wiki/Probit), rather than quantiles between 0 and 1, can be useful for machine learning and other tasks.

What changes are included in this PR?

Add a "rank_normal" function that computes array ranks as points on the normal distribution.

It is similar to calling the "rank_quantile" function and then applying the normal percent-point function ("probit").

Are these changes tested?

Yes, by dedicated unit tests.

Are there any user-facing changes?

No, except a new compute function.

Copy link

⚠️ GitHub issue #45572 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member Author

pitrou commented Feb 19, 2025

@zanmato1984 @WillAyd Does either of you want to take a look at this?

@pitrou
Copy link
Member Author

pitrou commented Feb 19, 2025

@github-actions crossbow submit -g cpp

Copy link

Revision: 21315d9

Submitted crossbow builds: ursacomputing/crossbow @ actions-77243e4960

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-meson GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Feb 19, 2025
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added Component: Python awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 20, 2025
@pitrou pitrou merged commit f9283d0 into apache:main Feb 20, 2025
38 checks passed
@pitrou pitrou removed the awaiting change review Awaiting change review label Feb 20, 2025
@pitrou pitrou deleted the gaussian-rank branch February 20, 2025 10:39
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f9283d0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants